From: David Ahern <dsahern@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: David Ahern <dsahern@gmail.com>
Subject: Re: [Patch net] addrconf: reduce unnecessary atomic allocations
Date: Wed, 22 Aug 2018 14:09:06 -0600 [thread overview]
Message-ID: <19f49b91-5f05-8d2e-4c20-38edd1993282@gmail.com> (raw)
In-Reply-To: <20180822195834.7217-1-xiyou.wangcong@gmail.com>
On 8/22/18 1:58 PM, Cong Wang wrote:
> All the 3 callers of addrconf_add_mroute() assert RTNL
> lock, they don't take any additional lock either, so
> it is safe to convert it to GFP_KERNEL.
>
> Same for sit_add_v4_addrs().
>
> Cc: David Ahern <dsahern@gmail.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
> net/ipv6/addrconf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Not sure how I missed the double ASSERT_RTNL() check for
sit_add_v4_addrs. Thanks for following up.
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2018-08-22 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 19:58 [Patch net] addrconf: reduce unnecessary atomic allocations Cong Wang
2018-08-22 20:09 ` David Ahern [this message]
2018-08-23 4:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f49b91-5f05-8d2e-4c20-38edd1993282@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).