From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [Patch net] addrconf: reduce unnecessary atomic allocations Date: Wed, 22 Aug 2018 14:09:06 -0600 Message-ID: <19f49b91-5f05-8d2e-4c20-38edd1993282@gmail.com> References: <20180822195834.7217-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: David Ahern To: Cong Wang , netdev@vger.kernel.org Return-path: Received: from mail-pg1-f170.google.com ([209.85.215.170]:35815 "EHLO mail-pg1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726581AbeHVXfZ (ORCPT ); Wed, 22 Aug 2018 19:35:25 -0400 Received: by mail-pg1-f170.google.com with SMTP id z4-v6so1419109pgv.2 for ; Wed, 22 Aug 2018 13:09:08 -0700 (PDT) In-Reply-To: <20180822195834.7217-1-xiyou.wangcong@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 8/22/18 1:58 PM, Cong Wang wrote: > All the 3 callers of addrconf_add_mroute() assert RTNL > lock, they don't take any additional lock either, so > it is safe to convert it to GFP_KERNEL. > > Same for sit_add_v4_addrs(). > > Cc: David Ahern > Signed-off-by: Cong Wang > --- > net/ipv6/addrconf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Not sure how I missed the double ASSERT_RTNL() check for sit_add_v4_addrs. Thanks for following up. Reviewed-by: David Ahern