From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AD432701B6 for ; Tue, 6 May 2025 10:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746526088; cv=none; b=EKjmUXqNbkZbSNkpiqeGr9CjGfPvJZJ0oHhBLt3TDd4eljOWr6DFhv7mdwbwklrCjeWtYImlBKVuv8lqdCI7byGuBSGjh2KW6b+RXg1yAHqOJzayIMVRQqJmr4p15SM+/d1YtZVRvZb7voFeTT8S5arHSTEkMr8JvrP+BBKBaRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746526088; c=relaxed/simple; bh=Wz6GfcLllA8wXtKZftbfMGr8twZTF0gIGI34vcXnxvA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Uk23mL14mgAtn8ytdDIxjtCazLn9bS1UxPi6fO87tI9+KA/WERkK5kX3QyQmJxEHO8DK98nTEWsEhpjY6FveqEDM8z+zSWi735x6Qjokp/Y83KkDJXBPQunwHLzFvngTL8KASTtAuQk2kQmhGg3WtVcyPAkuZwsrB51O/2+sUvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fVCYukBZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fVCYukBZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746526085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KtQkNqGsM537amwwqhIUa++uqwpFX6sC1hurxsMCHI=; b=fVCYukBZAHcpNHxC5l7aWX7MxV7r3Xaqfu8pedC+lsO3H0/OpjrnAl5l8/gjAw8U2qLuI9 ePCuOYmoJ5+qi/qWOtI+FzqEraPlzMHJCxxzZV8z0FBZDCPNv9z+r+xPAloQQVyRzT8fWU GMFahnY1ok+YbT7zeWqEHFMRRtnEzXg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-fscVzhC2MwaZWNm_Q-BVlg-1; Tue, 06 May 2025 06:08:04 -0400 X-MC-Unique: fscVzhC2MwaZWNm_Q-BVlg-1 X-Mimecast-MFC-AGG-ID: fscVzhC2MwaZWNm_Q-BVlg_1746526083 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cf172ff63so26288725e9.3 for ; Tue, 06 May 2025 03:08:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746526083; x=1747130883; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2KtQkNqGsM537amwwqhIUa++uqwpFX6sC1hurxsMCHI=; b=jQy91HjndQiX6sLDP8gxu4xI8orjpcoeMjRZxcaaVc7feGdVIFiBCln/8X8XvXs6bm WcNLx3yneBaLCkFzgppTIOvkRqNUNvLKbpZ34ZJMkZYRq8B1aNIRPX3KS/+TVPRuSBqd xyKAZvNaeClRq7VJxHyBkhN9b+/CN86MKtwf+yJ0kcyjY9BDf7mgBmZjzLAlv+rBLS1e pG4BDTcJaGeh3EMmKmWjT/OD78fFv9cO3+OCsog9XUX/aipUevZz3Y1hwPFwHUSfWcDy eko/dElGv62H7Lej97myjQnYXDoQJ4F9wkMLNGA21Eg5c9F53wGsjoNKvKy4FNlyNjzu lFQA== X-Forwarded-Encrypted: i=1; AJvYcCViGsoS3s9s3hsAv7YZlXulLtN63UXY0Upceasaf/LYkfKCTNVHrmwPl8KT5OGD0Amu+zSZVlU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6M2D1nYzvbA8BIGG7nIzhkKf/PfUR7B0p+6MBzZb6Oi1zyNWK 5ZjTTlVqiVPdg1+g4jwQbjUBF5DjirxUreEDYLcwYCX+b/O/iCRlPDIiVn2XaWQnaeFVhXwfKBf UkhIqo8HRHhKqZVWtDrHgGjahq+fh0XwcRImjU/Ch+4cZZHi3S2TurA== X-Gm-Gg: ASbGncsZlH3E9glt+1Uas1IjcZqQO3d1Es3yTFoWSNsx7/vLVNE4GuYPIhvekvGOXs8 FYs7B6CNVbwHjt34+kJyxQqrlxPOGjMdbokmlHMyWSC2KpGgRqV8HQHuybvTrjRFSaNACLy6Xe7 ACY2Lmh/SmP0gIyDJco9vO9nW7NKU1nPpai8OhIWscXebSyP4dsFCFpPiw6qiL3bPROF3lYhv8j sp3BwFImTaWo5Ord+8rLOuCxg7A/IxyQtp4JASSWPTo3GyQT7M8qxce7LkXPZKdRpXfiV6oRcv6 mVrHXkeBEFdyrr5ZvSFq4LUloYgB00pCiE5UpWNxZP6RFs8hjYUdXGv78LI= X-Received: by 2002:a05:600c:5304:b0:43c:fe15:41e1 with SMTP id 5b1f17b1804b1-441bbea0afbmr153287055e9.4.1746526082870; Tue, 06 May 2025 03:08:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhc03MBzoZWgjKorEMXR128n+knjgaDZEvqQTT3kpgSCz4Z047896lj5XIARk7un2ADQgeHA== X-Received: by 2002:a05:600c:5304:b0:43c:fe15:41e1 with SMTP id 5b1f17b1804b1-441bbea0afbmr153286675e9.4.1746526082521; Tue, 06 May 2025 03:08:02 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2706:e010:b099:aac6:4e70:6198? ([2a0d:3344:2706:e010:b099:aac6:4e70:6198]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2aecb60sm207881215e9.11.2025.05.06.03.07.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 May 2025 03:08:01 -0700 (PDT) Message-ID: <19f4f38b-9962-41d6-97b7-e254db3c6dee@redhat.com> Date: Tue, 6 May 2025 12:07:58 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 03/11] net: ti: prueth: Adds PRUETH HW and SW configuration To: Parvathi Pudi , danishanwar@ti.com, rogerq@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nm@ti.com, ssantosh@kernel.org, tony@atomide.com, richardcochran@gmail.com, glaroque@baylibre.com, schnelle@linux.ibm.com, m-karicheri2@ti.com, s.hauer@pengutronix.de, rdunlap@infradead.org, diogo.ivo@siemens.com, basharath@couthit.com, horms@kernel.org, jacob.e.keller@intel.com, m-malladi@ti.com, javier.carrasco.cruz@gmail.com, afd@ti.com, s-anna@ti.com Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, pratheesh@ti.com, prajith@ti.com, vigneshr@ti.com, praneeth@ti.com, srk@ti.com, rogerq@ti.com, krishna@couthit.com, pmohan@couthit.com, mohan@couthit.com References: <20250503121107.1973888-1-parvathi@couthit.com> <20250503121107.1973888-4-parvathi@couthit.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250503121107.1973888-4-parvathi@couthit.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/3/25 2:10 PM, Parvathi Pudi wrote: > +static int icssm_prueth_emac_config(struct prueth_emac *emac) > +{ > + struct prueth *prueth = emac->prueth; > + > + /* PRU needs local shared RAM address for C28 */ > + u32 sharedramaddr = ICSS_LOCAL_SHARED_RAM; > + > + /* PRU needs real global OCMC address for C30*/ > + u32 ocmcaddr = (u32)prueth->mem[PRUETH_MEM_OCMC].pa; > + void __iomem *dram_base; > + void __iomem *mac_addr; > + void __iomem *dram; Minor nit: please respect the reverse christmas tree order above. /P