From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A40C282C7 for ; Sat, 26 Jan 2019 14:04:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5EAC21872 for ; Sat, 26 Jan 2019 14:04:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mEm4U7Ic" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726225AbfAZOEq (ORCPT ); Sat, 26 Jan 2019 09:04:46 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55415 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfAZOEq (ORCPT ); Sat, 26 Jan 2019 09:04:46 -0500 Received: by mail-wm1-f66.google.com with SMTP id y139so9244067wmc.5 for ; Sat, 26 Jan 2019 06:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IBzWF/Vj+6pAccNWXOtioIVMt62EQAY34iJY52BfzTw=; b=mEm4U7Icg1y4Ali94G0k6NcCQMP3TYKrUQFnWe7cqyD2XlGuBCtsdZ/it/22tUoxT6 n3w/DQUr86EFMcFe8wFDuuwvVHtoGlBAN0aQZ4rwFBfrzeGhxiA93AuP6VqNal9IVP2f RyzYQ8a0a+4dFGCOwXFCyBIo5KCGzc/UyhSpuN7tVnKtUlBBsreQrEIN8xeaM9G+halt Ycz3FbiZYoUixBhfoOqDDHvsG/Ix9QK5BvRNCPz0uojhr5BvAajralxyLrxMhKAavO83 rtS/qWeMibzCGnyDVM1f6YpkJJQWixMzj5UGLhXbYbNJHENAfWkijmMQuXPHK/iqbeP8 NnKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IBzWF/Vj+6pAccNWXOtioIVMt62EQAY34iJY52BfzTw=; b=NwN5WWtYMCzeI/igPMFIO+9C+uAPVtt8udDQzomlfY0ZZYrW+bi6G32ggRikzDqmul RsdjKVaM8VhvzvVeH/Lx+VJc7HFMFhqBtUDwBaMdBLeyKWU/ho/3tMBs9qjnyPXwMfm5 n1nqAJEJE+c1dIPUh9wI0i3KJj6YNc5FPyH81gYa7hh07wxOg0bKLxppFuLYtjr9nKEQ 3vhL7QdTYk/L+z/PhTQz/AnEeVIZEZXpoYcRi1w4MxNoZBbI24mOJZKAHM3jKic9u3R7 y/5qqhsPrawlaSHWGr8ujJN96q22Yn1FyZZJ9PhJFXJrE9XhwOFR4QPgt/HnDxJ4U8HG uS0g== X-Gm-Message-State: AJcUukcz27d4Qu9QgGxBDa7BdvULSBgAefJlmkroLeitIgh+tQ5TlXfR LCuiHrOvhwbsdq7AOPzXqSUjcrNN X-Google-Smtp-Source: ALg8bN45PjkVzGHaxeqY/GFua8CQx+97PV0aAiaoAAp1T9/fBXbihEeq+uonYV6yyoXLdXgqbLAw9w== X-Received: by 2002:a1c:6707:: with SMTP id b7mr10546797wmc.138.1548511484464; Sat, 26 Jan 2019 06:04:44 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:e416:5520:9c93:d4eb? (p200300EA8BF1E200E41655209C93D4EB.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:e416:5520:9c93:d4eb]) by smtp.googlemail.com with ESMTPSA id q12sm98154227wrx.31.2019.01.26.06.04.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Jan 2019 06:04:43 -0800 (PST) Subject: Re: WoL broken in r8169.c since kernel 4.19 To: Marc Haber Cc: "netdev@vger.kernel.org" References: <20190112200831.GB20268@torres.zugschlus.de> <20190113160149.GG20268@torres.zugschlus.de> <04cbac76-e0c4-dc97-4a11-0dc7d85be276@gmail.com> <20190122161005.GA27062@torres.zugschlus.de> <3c3249f8-6e09-43a7-e4e2-f4fc2b9531ab@gmail.com> <20190125055919.GB27062@torres.zugschlus.de> <6ae02156-8903-70fd-675f-a5aee9c452b4@gmail.com> <20190125120210.GC27062@torres.zugschlus.de> <548c1682-ad7c-3a0a-b2ea-2207f328b070@gmail.com> <20190126135640.GD27062@torres.zugschlus.de> From: Heiner Kallweit Message-ID: <1a17454a-3017-7283-89d6-206681ca4c47@gmail.com> Date: Sat, 26 Jan 2019 15:04:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190126135640.GD27062@torres.zugschlus.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 26.01.2019 14:56, Marc Haber wrote: > On Fri, Jan 25, 2019 at 07:22:36PM +0100, Heiner Kallweit wrote: >> Then I'm slowly running out of ideas. New in 4.19 is a check for invalid >> WoL flags, but usually the caller should warn if -EINVAL is returned. >> Nevertheless, could you try the following and check whether the warning >> is triggered? > > Compiled the kernel, went through the motions: > > - boot > - suspend > - try unsuccessful WoL > - wake up manually > - do ethtool gymnastics > - suspend > - try successful WoL > - grep syslog for "WoL", nothing found. > Thanks for testing. Then the only way to find the offending commit is bisecting. Let me know if you need support. I can't reproduce the issue on latest kernels even though RTL8168evl and RTL8168g use the same WoL code path. > Greetings > Marc > Heiner