From: Florian Fainelli <f.fainelli@gmail.com>
To: "André Przywara" <andre.przywara@arm.com>,
"Andrew Lunn" <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Doug Berger <opendmb@gmail.com>
Subject: Re: [PATCH] net: PHY: bcm-unimac: Fix clock handling
Date: Tue, 24 Mar 2020 10:13:53 -0700 [thread overview]
Message-ID: <1a190001-db8a-4c4c-909e-9ef475a58ed3@gmail.com> (raw)
In-Reply-To: <5852f0e7-aea8-7af8-3a88-5e4fcdc6e5d4@arm.com>
On 3/24/2020 9:26 AM, André Przywara wrote:
> On 24/03/2020 16:17, Andrew Lunn wrote:
>
> Hi,
>
>> On Tue, Mar 24, 2020 at 04:10:10PM +0000, Andre Przywara wrote:
>>> The DT binding for this PHY describes an *optional* clock property.
>>> Due to a bug in the error handling logic, we are actually ignoring this
>>> clock *all* of the time so far.
>>>
>>> Fix this by using devm_clk_get_optional() to handle this clock properly.
>>>
>>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>>
>> Hi Andre
>>
>> Do you have a fixes: tag for this?
>
> Should be:
> Fixes: b78ac6ecd1b6b ("net: phy: mdio-bcm-unimac: Allow configuring MDIO
> clock divider")
>
>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Thanks for that!
And the subject should be:
net: phy: mdio-bcm-unimac: Fix clock handling
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-03-24 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 16:10 [PATCH] net: PHY: bcm-unimac: Fix clock handling Andre Przywara
2020-03-24 16:17 ` Andrew Lunn
2020-03-24 16:26 ` André Przywara
2020-03-24 17:13 ` Florian Fainelli [this message]
2020-03-24 23:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a190001-db8a-4c4c-909e-9ef475a58ed3@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andre.przywara@arm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).