From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next v2 03/10] r8169: replace open-coded PHY soft reset with genphy_soft_reset Date: Wed, 11 Jul 2018 04:10:34 -0700 Message-ID: <1a2bc7d7-606f-758a-a33c-09ea7d253d8b@gmail.com> References: <84ac1cb7-bafd-5f15-8cda-e8dfd7d0deb3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Heiner Kallweit , David Miller , Andrew Lunn , Realtek linux nic maintainers Return-path: Received: from mail-qt0-f194.google.com ([209.85.216.194]:44162 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726641AbeGKLO0 (ORCPT ); Wed, 11 Jul 2018 07:14:26 -0400 Received: by mail-qt0-f194.google.com with SMTP id b15-v6so20838028qtp.11 for ; Wed, 11 Jul 2018 04:10:38 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/10/2018 11:39 AM, Heiner Kallweit wrote: > Use genphy_soft_reset() instead of open-coding a PHY soft reset. We have > to do an explicit PHY soft reset because some chips use the genphy driver > which uses a no-op as soft_reset callback. > > Signed-off-by: Heiner Kallweit > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian