Netdev List
 help / color / mirror / Atom feed
From: Nicolai Buchwitz <nb@tipi-net.de>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: netdev@vger.kernel.org, Carlos Soto <carlos.soto@broadcom.com>,
	Justin Chen <justin.chen@broadcom.com>,
	Doug Berger <opendmb@gmail.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-kernel@vger.kernel.org, Mlody12 mlody12 <kudzo51@gmail.com>
Subject: Re: [PATCH net-next 3/3] net: mdio: mdio-bcm-unimac: Add Clause 45 support
Date: Tue, 17 Nov 2026 10:32:02 +0100	[thread overview]
Message-ID: <1a2bd644b2430c88976baa29043d9c4f@tipi-net.de> (raw)
In-Reply-To: <3996fa8c-3346-40ff-8fa0-afa70262028b@broadcom.com>

Hi Florian

On 16.11.2026 19:54, Florian Fainelli wrote:

> [...]

>>> @@ -301,6 +390,8 @@ static int unimac_mdio_probe(struct 
>>> platform_device *pdev)
>>>      bus->parent = &pdev->dev;
>>>      bus->read = unimac_mdio_read;
>>>      bus->write = unimac_mdio_write;
>>> +    bus->read_c45 = unimac_mdio_read_c45;
>>> +    bus->write_c45 = unimac_mdio_write_c45;
>> 
>> AFAIU this breaks GENET without DT (e.g. Pi 4 with ACPI). Arguably an 
>> edge case,
>> but last time I tried it worked at least. With your changes all 
>> addresses get
>> a C45 scan there for which the empty ones return -EIO. 
>> get_phy_c45_ids() passes
>> that up instead of mapping it to -ENODEV like the C22 path.
>> 
>> A cheap fix would be to do the same mapping in get_phy_c45_ids() as we 
>> have for C22.
> 
> OK, are we the only platform where that is happening? Alignment would 
> make sense, and I don't assume we will be breaking someone's use case 
> AFAICT.

The only other I could find ois orion_mdio_xsmi_read_c45 
(marvell/mvmdio.c)

Regards
Nicolai

  reply	other threads:[~2026-11-17  9:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 21:15 [PATCH net-next 0/3] net: mdio: Clause 45 support for Florian Fainelli
2026-11-13 21:15 ` [PATCH net-next 1/3] net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT Florian Fainelli
2026-11-13 21:55   ` Andrew Lunn
2026-11-15 18:49   ` Nicolai Buchwitz
2026-11-13 21:15 ` [PATCH net-next 2/3] net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity Florian Fainelli
2026-11-13 21:58   ` Andrew Lunn
2026-11-15 18:51   ` Nicolai Buchwitz
2026-11-13 21:15 ` [PATCH net-next 3/3] net: mdio: mdio-bcm-unimac: Add Clause 45 support Florian Fainelli
2026-11-13 22:04   ` Andrew Lunn
2026-11-13 22:14     ` Florian Fainelli
2026-11-15 18:59   ` Nicolai Buchwitz
2026-11-16 18:54     ` Florian Fainelli
2026-11-17  9:32       ` Nicolai Buchwitz [this message]
2026-11-14  0:00 ` [PATCH net-next 0/3] net: mdio: Clause 45 support for Kordian Chmielewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a2bd644b2430c88976baa29043d9c4f@tipi-net.de \
    --to=nb@tipi-net.de \
    --cc=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=carlos.soto@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=hkallweit1@gmail.com \
    --cc=justin.chen@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=kudzo51@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox