From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21C520CCE3; Mon, 26 May 2025 13:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748266454; cv=none; b=CMQhuIA9I6M2R37/iJTX1oob8gqpx4f7qdirQth5jUueJ4lMh1zXZptU5BTRAyF0oKsZk0zH6qNR+QDkcP3TjuiF1690HQXYOYDksAzWUxXlvxzpFQksAaS/SI1oOmAswkEoUzfT2M1JIPcOyfKMmg8ygucI0ReYkd2e7Ycl0XQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748266454; c=relaxed/simple; bh=FRBuviFhvwRiqro8X8chmfWguThYA9CbrHVfEKsY1Qw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cqQozdQooMXi2Jy5aMxjcuLAl9XcCh30PRm4dl8ex6qyFHIACtNHeJapG57slee8diCFMAkS+DY/cB6J6eXd+MTpB7XloEAY5v/014+R1l/4nFXhrpZrxy2tS820ZgsU9IYy4tg7rWnpO1c81QDI7eHXCzvsGDShGjXhsqYvZic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=FHgAgwE7; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="FHgAgwE7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=IZAn8xJlkBn0BeuCUV7NjDGcKQINtg4KUlNlcZZtIkU=; b=FHgAgwE7+cikHDPIChRxA1XoNl s/u1wQA0799Q8L6uMR8FSiEsNxcOYW7TWXC3UCZ+xCz0XyxovWF3G7slW41+3Cjks/Kn/Z916GOV9 Ofr99MnqQnls8QFDChASchsHYgmaHo77Hlipq1zA9vv7B4YLuj/22rV0XCcG8eeI7wKg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uJXxq-00E0DO-IG; Mon, 26 May 2025 15:34:02 +0200 Date: Mon, 26 May 2025 15:34:02 +0200 From: Andrew Lunn To: George Moussalem Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Philipp Zabel , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support Message-ID: <1a6caebd-251f-4929-a7cf-af7c38ca30ed@lunn.ch> References: <20250525-ipq5018-ge-phy-v1-0-ddab8854e253@outlook.com> <20250525-ipq5018-ge-phy-v1-1-ddab8854e253@outlook.com> <579b0db7-523c-46fd-897b-58fa0af2a613@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > I couldn't agree more but I just don't know what these values are exactly as > they aren't documented anywhere. I'm working off the downstream QCA-SSDK > codelinaro repo. My *best guess* for the MDAC value is that it halves the > amplitude and current for short cable length, but I don't know what > algorithm is used for error detection and correction. > > What I do know is that values must be written in a phy to phy link > architecture as the 'cable length' is short, a few cm at most. Without > setting these values, the link doesn't work. > > With the lack of proper documentation, I could move the values to the driver > itself and convert it to a boolean property such as qca,phy-to-phy-dac or > something.. Making it a boolean property is good. Please include in the binding the behaviour when the bool is not present. What you are really describing here is a sort cable, not phy-to-phy, since a PHY is always connected to another PHY. So i think the property name should be about the sort cable/distance. Andrew