From: David Decotigny <david.decotigny@google.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Ian Campbell <ian.campbell@citrix.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
Szymon Janc <szymon@janc.net.pl>,
Richard Jones <rick.jones2@hp.com>,
Ayaz Abdulla <AAbdulla@nvidia.com>,
David Decotigny <david.decotigny@google.com>
Subject: [PATCH net-next v5 02/10] net-sysfs: fixed minor sparse warning
Date: Tue, 15 Nov 2011 21:15:50 -0800 [thread overview]
Message-ID: <1a71b137887d15a0bad8af7c931b8795ee7f20b7.1321420513.git.david.decotigny@google.com> (raw)
In-Reply-To: <cover.1321420513.git.david.decotigny@google.com>
In-Reply-To: <cover.1321420513.git.david.decotigny@google.com>
This commit fixes following warning:
net/core/net-sysfs.c:921:6: warning: symbol 'numa_node' shadows an earlier one
include/linux/topology.h:222:1: originally declared here
Signed-off-by: David Decotigny <david.decotigny@google.com>
---
net/core/net-sysfs.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index c71c434..a64382f 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -901,7 +901,7 @@ static ssize_t store_xps_map(struct netdev_queue *queue,
struct xps_map *map, *new_map;
struct xps_dev_maps *dev_maps, *new_dev_maps;
int nonempty = 0;
- int numa_node = -2;
+ int numa_node_id = -2;
if (!capable(CAP_NET_ADMIN))
return -EPERM;
@@ -944,10 +944,10 @@ static ssize_t store_xps_map(struct netdev_queue *queue,
need_set = cpumask_test_cpu(cpu, mask) && cpu_online(cpu);
#ifdef CONFIG_NUMA
if (need_set) {
- if (numa_node == -2)
- numa_node = cpu_to_node(cpu);
- else if (numa_node != cpu_to_node(cpu))
- numa_node = -1;
+ if (numa_node_id == -2)
+ numa_node_id = cpu_to_node(cpu);
+ else if (numa_node_id != cpu_to_node(cpu))
+ numa_node_id = -1;
}
#endif
if (need_set && pos >= map_len) {
@@ -997,7 +997,7 @@ static ssize_t store_xps_map(struct netdev_queue *queue,
if (dev_maps)
kfree_rcu(dev_maps, rcu);
- netdev_queue_numa_node_write(queue, (numa_node >= 0) ? numa_node :
+ netdev_queue_numa_node_write(queue, (numa_node_id >= 0) ? numa_node_id :
NUMA_NO_NODE);
mutex_unlock(&xps_map_mutex);
--
1.7.3.1
next prev parent reply other threads:[~2011-11-16 5:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 5:15 [PATCH net-next v5 00/10] net-sysfs+forcedeth: stats & debug enhancements David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 01/10] forcedeth: fix stats on hardware without extended stats support David Decotigny
2011-11-16 5:15 ` David Decotigny [this message]
2011-11-16 5:15 ` [PATCH net-next v5 03/10] kbuild: document RPS/XPS network Kconfig options David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 04/10] net: provide counter for tx_timeout errors in sysfs David Decotigny
2011-11-16 16:51 ` Stephen Hemminger
2011-11-16 5:15 ` [PATCH net-next v5 05/10] forcedeth: Add messages to indicate using MSI or MSI-X David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 06/10] forcedeth: allow to silence "TX timeout" debug messages David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 07/10] forcedeth: implement ndo_get_stats64() API David Decotigny
2011-11-16 16:55 ` Stephen Hemminger
2011-11-16 17:14 ` Ben Hutchings
2011-11-16 19:25 ` David Decotigny
2011-11-16 19:32 ` Ben Hutchings
2011-11-16 20:32 ` Eric Dumazet
2011-11-16 20:46 ` David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 08/10] forcedeth: account for dropped RX frames David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 09/10] forcedeth: stats updated with a deferrable timer David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 10/10] forcedeth: whitespace/indentation fixes David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a71b137887d15a0bad8af7c931b8795ee7f20b7.1321420513.git.david.decotigny@google.com \
--to=david.decotigny@google.com \
--cc=AAbdulla@nvidia.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).