From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
intel-wired-lan@lists.osuosl.org,
Donald Hunter <donald.hunter@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH] ethtool: add FEC bins histogramm report
Date: Tue, 29 Jul 2025 17:01:06 +0100 [thread overview]
Message-ID: <1a7f0aa0-47ae-4936-9e55-576cdf71f4cc@linux.dev> (raw)
In-Reply-To: <982c780a-1ff1-4d79-9104-c61605c7e802@lunn.ch>
On 29/07/2025 14:48, Andrew Lunn wrote:
>> + name: fec-hist-bin-low
>> + type: s32
>
> Signed 32 bit
>
>> +struct ethtool_fec_hist_range {
>> + s16 low;
>
> Signed 16 bit.
>
>> + if (nla_put_u32(skb, ETHTOOL_A_FEC_STAT_FEC_HIST_BIN_LOW,
>> + ranges[i].low) ||
>
> Unsigned 32 bit.
>
> Could we have some consistency with the types.
Yeah, it looks a bit messy. AFAIK, any type of integer less than 32 bits
will be extended to 32 bits anyway, so I believe it's ok to keep smaller
memory footprint for the histogram definition in the driver but still
use s32 as netlink attr type. I'll change the code to use nla_put_s32()
to keep sign info.
Does it look OK?
>
> Andrew
next prev parent reply other threads:[~2025-07-29 16:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 10:23 [RFC PATCH] ethtool: add FEC bins histogramm report Vadim Fedorenko
2025-07-29 13:48 ` Andrew Lunn
2025-07-29 16:01 ` Vadim Fedorenko [this message]
2025-07-29 16:17 ` Andrew Lunn
2025-07-29 16:36 ` Vadim Fedorenko
2025-07-29 17:31 ` Andrew Lunn
2025-07-29 18:07 ` Vadim Fedorenko
2025-07-30 1:51 ` Jakub Kicinski
2025-07-30 5:39 ` Gal Pressman
2025-07-30 12:59 ` Andrew Lunn
2025-07-30 13:54 ` Gal Pressman
2025-07-30 9:18 ` Vadim Fedorenko
2025-07-30 13:44 ` Jakub Kicinski
2025-07-30 14:39 ` Vadim Fedorenko
2025-07-30 1:45 ` Jakub Kicinski
2025-07-30 9:22 ` Vadim Fedorenko
2025-07-30 13:45 ` Jakub Kicinski
2025-07-30 1:48 ` Jakub Kicinski
2025-07-30 5:54 ` Gal Pressman
2025-07-30 9:29 ` Vadim Fedorenko
2025-07-30 10:42 ` Gal Pressman
2025-07-30 11:32 ` Vadim Fedorenko
2025-07-30 13:47 ` Gal Pressman
2025-07-30 14:15 ` Andrew Lunn
2025-07-30 12:08 ` Carolina Jubran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a7f0aa0-47ae-4936-9e55-576cdf71f4cc@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew@lunn.ch \
--cc=donald.hunter@gmail.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox