From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20 Date: Tue, 23 Aug 2016 11:57:30 -0400 Message-ID: <1a97f16d-5a0a-cb06-6e5c-1b6f9fa7c609@redhat.com> References: <1471942157-9131-1-git-send-email-saeedm@mellanox.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5ieuEcsPVF5boSSWCXUXhbudTw6NniAGU" Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky , Tal Alon , Matan Barak To: Saeed Mahameed , "David S. Miller" Return-path: In-Reply-To: <1471942157-9131-1-git-send-email-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5ieuEcsPVF5boSSWCXUXhbudTw6NniAGU Content-Type: multipart/mixed; boundary="06HMUsop3s1gSMV9OlHa6CmTfLdkldrP9" From: Doug Ledford To: Saeed Mahameed , "David S. Miller" Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky , Tal Alon , Matan Barak Message-ID: <1a97f16d-5a0a-cb06-6e5c-1b6f9fa7c609-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Subject: Re: [for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20 References: <1471942157-9131-1-git-send-email-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> In-Reply-To: <1471942157-9131-1-git-send-email-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> --06HMUsop3s1gSMV9OlHa6CmTfLdkldrP9 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/23/2016 4:49 AM, Saeed Mahameed wrote: > Hi Dave and Doug, >=20 > This series contains several low level and API updates for mlx5 core > commands interface and mlx5_ifc.h to be shared as base code for net-nex= t and > rdma mlx5 4.9 submissions. >=20 > From Saeed, ten patches that refactors old layouts of firmware commands= which=20 > were manually generated before we introduced the mlx5_ifc, now all of t= he firmware > commands inbox/outbox layouts moved to use mlx5_ifc and we remove the o= ld > manually generated structures. These all looked fine to me. > Plus to those ten patches, we add two patches > that unifies mlx5 commands execution interface and improve the driver l= og messages > in that area. These are the patches that made my eyes want to bleed. But, since it's all changes to the mailbox commands being sent to your device, they are easy to verify operationally, so I only gave these a cursory review and expect if any of your commands broke because of this you'll be submitting fixes ASAP. > From Hadar and Ilya, added the needed hardware bits and infrastructure = for > minimum inline headers setting and encap/decap commands and capabilitie= s, > needed for E-Switch offloads. These looked fine to me, but aren't really in the RDMA area anyway. > This series applies on top latest net-next and rdma/master, and smoothl= y merges with > the latest "Mellanox 100G mlx5 fixes 2016-08-16" series already applied= into net branch. >=20 > The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a= 7cfc: > Linux 4.8-rc1 >=20 > are available in the git repository at: > git://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git t= ags/shared-for-4.9-1 I've pulled these into a local branch and they look fine. Once Dave gives his ack/nack, we'll go from there. > for you to fetch changes up to 575ddf5888eaf8f271cb3df7b0806cb2db2c333a= : > net/mlx5: Introduce alloc_encap and dealloc_encap commands >=20 > Changes since V2 and V1: > - Reduce the number of patches and changed the cover letter respect= ively. >=20 > Thanks, > Saeed & Leon. >=20 > Hadar Hen Zion (2): > net/mlx5: Enable setting minimum inline header mode for VFs > net/mlx5: Update mlx5_ifc.h for vxlan encap/decap >=20 > Ilya Lesokhin (1): > net/mlx5: Introduce alloc_encap and dealloc_encap commands >=20 > Saeed Mahameed (12): > net/mlx5: Init/Teardown hca commands via mlx5 ifc > net/mlx5: Access register and MAD IFC commands via mlx5 ifc > net/mlx5: PD and UAR commands via mlx5 ifc > net/mlx5: MCG commands via mlx5 ifc > net/mlx5: Pages management commands via mlx5 ifc > net/mlx5: EQ commands via mlx5 ifc > {net,IB}/mlx5: CQ commands via mlx5 ifc > {net,IB}/mlx5: MKey/PSV commands via mlx5 ifc > {net,IB}/mlx5: QP/XRCD commands via mlx5 ifc > {net,IB}/mlx5: Modify QP commands via mlx5 ifc > net/mlx5: Unify and improve command interface > net/mlx5: Improve driver log messages >=20 > drivers/infiniband/hw/mlx5/cq.c | 110 +++--- > drivers/infiniband/hw/mlx5/main.c | 10 +- > drivers/infiniband/hw/mlx5/mlx5_ib.h | 2 +- > drivers/infiniband/hw/mlx5/mr.c | 184 +++++---- > drivers/infiniband/hw/mlx5/qp.c | 189 ++++----- > drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 261 +++++++------= > drivers/net/ethernet/mellanox/mlx5/core/cq.c | 109 ++---- > drivers/net/ethernet/mellanox/mlx5/core/debugfs.c | 50 +-- > .../net/ethernet/mellanox/mlx5/core/en_common.c | 23 +- > .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 +- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 47 +-- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 4 +- > drivers/net/ethernet/mellanox/mlx5/core/eq.c | 80 ++-- > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 98 ++--- > drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c | 178 ++++----- > drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.h | 7 + > drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 18 +- > drivers/net/ethernet/mellanox/mlx5/core/fw.c | 43 +-- > drivers/net/ethernet/mellanox/mlx5/core/mad.c | 41 +- > drivers/net/ethernet/mellanox/mlx5/core/main.c | 91 ++--- > drivers/net/ethernet/mellanox/mlx5/core/mcg.c | 72 +--- > .../net/ethernet/mellanox/mlx5/core/mlx5_core.h | 17 +- > drivers/net/ethernet/mellanox/mlx5/core/mr.c | 189 ++++----- > .../net/ethernet/mellanox/mlx5/core/pagealloc.c | 156 +++----- > drivers/net/ethernet/mellanox/mlx5/core/pd.c | 61 +-- > drivers/net/ethernet/mellanox/mlx5/core/port.c | 149 +++---- > drivers/net/ethernet/mellanox/mlx5/core/qp.c | 299 ++++++++-----= - > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 11 +- > drivers/net/ethernet/mellanox/mlx5/core/sriov.c | 7 +- > drivers/net/ethernet/mellanox/mlx5/core/srq.c | 49 +-- > drivers/net/ethernet/mellanox/mlx5/core/transobj.c | 183 +++------ > drivers/net/ethernet/mellanox/mlx5/core/uar.c | 67 +--- > drivers/net/ethernet/mellanox/mlx5/core/vport.c | 94 ++--- > drivers/net/ethernet/mellanox/mlx5/core/vxlan.c | 29 +- > include/linux/mlx5/cq.h | 6 +- > include/linux/mlx5/device.h | 429 +------------= -------- > include/linux/mlx5/driver.h | 20 +- > include/linux/mlx5/mlx5_ifc.h | 116 +++++- > include/linux/mlx5/qp.h | 128 +----- > include/linux/mlx5/vport.h | 2 + > 40 files changed, 1390 insertions(+), 2242 deletions(-) >=20 --=20 Doug Ledford GPG Key ID: 0E572FDD --06HMUsop3s1gSMV9OlHa6CmTfLdkldrP9-- --5ieuEcsPVF5boSSWCXUXhbudTw6NniAGU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJXvHJrAAoJELgmozMOVy/dUFgP+wcWxJ+OnLoorv2LKe3yyALR FpESG85Q8aKrX6BPr+WAkatA02rWt9s8dDIFyMVY6ajgo8iqhYtAfApTOd8MwD0r NY2+rZ4YoLOVEWM/lLXsoUVj4P5TS0TfaDUEToGA+npph9EqA7nnL5ekyW662XPp 1t14JUbIGccrp6/7yJ7ztRAD4d+8Ldbe5aiS1YiWCeYT9XwMCEUXO91zl+nwfQQ4 LJTaXTAQykTJ7ws7whI2CuLa9NJvZKrjygOJN92VxW8cVLsM9dh1mCO8NGf7GQJW IZ2vaSu6RkhKPMYs+Rr/UJh3mwOXeHLPfFagjcO4h1CGGje5T5MRmWsTPD4Vv8Fu k8XCybQsxSBzIyIyofT+3+4sh7j1rbjq0IBK27BjZjJcnZhwBigeHH9A+hBjiyXi /sFI5b3IzefCw8K19MKql8TSa6oLiaoXpEtsfVxM9brxVGL2yn7fq9WOwCBBFOhJ 8FIAAPctH3Pm6h3MGySQeCLEEY1KYASVyNv95AljKRFChMsmLt/l/c9XRNZ7hCEX fZQ2yaNgCYiD/0XKdq1H35a6uBqxr4WlfXpMzqIZ+6zemxfEzxUxsxjlYj/S+CzR 4wZ+hQWINO9Dy3noyFRgkinqNL3wwK8VzN6N0RW08qDBYHtQmjdFP5v3GJiLCiXm oPisLUM+N9KuSeBvY7ND =noOt -----END PGP SIGNATURE----- --5ieuEcsPVF5boSSWCXUXhbudTw6NniAGU-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html