From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH v4 iproute2 net-next] erspan: add erspan version II support Date: Mon, 25 Dec 2017 16:44:18 -0600 Message-ID: <1ac019fb-1a91-3664-affe-43a0d4a3502a@gmail.com> References: <1513735266-116453-1-git-send-email-u9012063@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: William Tu , netdev@vger.kernel.org Return-path: Received: from mail-io0-f193.google.com ([209.85.223.193]:35004 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbdLYWoV (ORCPT ); Mon, 25 Dec 2017 17:44:21 -0500 Received: by mail-io0-f193.google.com with SMTP id 14so24698656iou.2 for ; Mon, 25 Dec 2017 14:44:21 -0800 (PST) In-Reply-To: <1513735266-116453-1-git-send-email-u9012063@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/19/17 8:01 PM, William Tu wrote: > The patch adds support for configuring the erspan v2, for both > ipv4 and ipv6 erspan implementation. Three additional fields > are added: 'erspan_ver' for distinguishing v1 or v2, 'erspan_dir' > for specifying direction of the mirrored traffic, and 'erspan_hwid' > for users to set ERSPAN engine ID within a system. > > As for manpage, the ERSPAN descriptions used to be under GRE, IPIP, > SIT Type paragraph. Since IP6GRE/IP6GRETAP also supports ERSPAN, > the patch removes the old one, creates a separate ERSPAN paragrah, > and adds an example. > > Signed-off-by: William Tu > --- > change in v4: > - use matches instead of strcmp on ingress/egress > change in v3: > - change erspan_dir 0/1 to "in[gress]/e[gress]" > - update manpage > change in v2: > - fix typo ETH_P_ERSPAN2 > - fix space and indent > --- > include/uapi/linux/if_ether.h | 1 + > include/uapi/linux/if_tunnel.h | 3 ++ > ip/link_gre.c | 66 ++++++++++++++++++++++++++++-- > ip/link_gre6.c | 67 ++++++++++++++++++++++++++++-- > man/man8/ip-link.8.in | 92 ++++++++++++++++++++++++++++++++++++------ > 5 files changed, 210 insertions(+), 19 deletions(-) This was applied to iproute2 net-next: https://git.kernel.org/pub/scm/linux/kernel/git/dsahern/iproute2-next.git/