* [PATCH net-next 4/5] dsa: Microchip KSZ switches SPI devicetree configuration
@ 2017-05-05 23:18 Woojung.Huh
2017-05-06 3:54 ` Andrew Lunn
2017-05-06 10:02 ` Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Woojung.Huh @ 2017-05-05 23:18 UTC (permalink / raw)
To: andrew, f.fainelli, vivien.didelot; +Cc: netdev, davem, UNGLinuxDriver
From: Woojung Huh <Woojung.Huh@microchip.com>
A sample SPI configuration for Microchip KSZ switches.
Signed-off-by: Woojung Huh <Woojung.Huh@microchip.com>
---
Documentation/devicetree/bindings/net/dsa/ksz.txt | 73 +++++++++++++++++++++++
1 file changed, 73 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/dsa/ksz.txt
diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
new file mode 100644
index 0000000..9cca7d4
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
@@ -0,0 +1,73 @@
+Microchip KSZ Series Ethernet switches
+==================================
+
+Required properties:
+
+- compatible: For external switch chips, compatible string must be exactly one
+ of: "microchip,ksz9477"
+
+See Documentation/devicetree/bindings/dsa/dsa.txt for a list of additional
+required and optional properties.
+
+Examples:
+
+Ethernet switch connected via SPI to the host, CPU port wired to eth0:
+
+ eth0: ethernet@10001000 {
+ fixed-link {
+ reg = <7>
+ speed = <1000>;
+ duplex-full;
+ };
+ };
+
+ spi1: spi@f8008000 {
+ pinctrl-0 = <&pinctrl_spi_ksz>;
+ cs-gpios = <&pioC 25 0>;
+ id = <1>;
+ status = "okay";
+
+ ksz9477: ksz9477@0 {
+ compatible = "microchip,ksz9477";
+ reg = <0>;
+
+ spi-max-frequency = <44000000>;
+ spi-cpha;
+ spi-cpol;
+
+ status = "okay";
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ label = "lan1";
+ };
+ port@1 {
+ reg = <1>;
+ label = "lan2";
+ };
+ port@2 {
+ reg = <2>;
+ label = "lan3";
+ };
+ port@3 {
+ reg = <3>;
+ label = "lan4";
+ };
+ port@4 {
+ reg = <4>;
+ label = "lan5";
+ };
+ port@5 {
+ reg = <5>;
+ label = "cpu";
+ ethernet = <&macb0>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next 4/5] dsa: Microchip KSZ switches SPI devicetree configuration
2017-05-05 23:18 [PATCH net-next 4/5] dsa: Microchip KSZ switches SPI devicetree configuration Woojung.Huh
@ 2017-05-06 3:54 ` Andrew Lunn
2017-05-06 10:02 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2017-05-06 3:54 UTC (permalink / raw)
To: Woojung.Huh; +Cc: f.fainelli, vivien.didelot, netdev, davem, UNGLinuxDriver
On Fri, May 05, 2017 at 11:18:05PM +0000, Woojung.Huh@microchip.com wrote:
> From: Woojung Huh <Woojung.Huh@microchip.com>
>
> A sample SPI configuration for Microchip KSZ switches.
>
> Signed-off-by: Woojung Huh <Woojung.Huh@microchip.com>
> ---
> Documentation/devicetree/bindings/net/dsa/ksz.txt | 73 +++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/dsa/ksz.txt
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> new file mode 100644
> index 0000000..9cca7d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> @@ -0,0 +1,73 @@
> +Microchip KSZ Series Ethernet switches
> +==================================
> +
> +Required properties:
> +
> +- compatible: For external switch chips, compatible string must be exactly one
> + of: "microchip,ksz9477"
> +
> +See Documentation/devicetree/bindings/dsa/dsa.txt for a list of additional
> +required and optional properties.
> +
> +Examples:
> +
> +Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> +
> + eth0: ethernet@10001000 {
> + fixed-link {
> + reg = <7>
> + speed = <1000>;
> + duplex-full;
> + };
> + };
> +
..
> + port@5 {
> + reg = <5>;
> + label = "cpu";
> + ethernet = <&macb0>;
I think this should be ethernet = <ð0>;
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next 4/5] dsa: Microchip KSZ switches SPI devicetree configuration
2017-05-05 23:18 [PATCH net-next 4/5] dsa: Microchip KSZ switches SPI devicetree configuration Woojung.Huh
2017-05-06 3:54 ` Andrew Lunn
@ 2017-05-06 10:02 ` Sergei Shtylyov
2017-05-07 1:04 ` Woojung.Huh
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2017-05-06 10:02 UTC (permalink / raw)
To: Woojung.Huh, andrew, f.fainelli, vivien.didelot
Cc: netdev, davem, UNGLinuxDriver
Hello!
On 5/6/2017 2:18 AM, Woojung.Huh@microchip.com wrote:
> From: Woojung Huh <Woojung.Huh@microchip.com>
>
> A sample SPI configuration for Microchip KSZ switches.
>
> Signed-off-by: Woojung Huh <Woojung.Huh@microchip.com>
> ---
> Documentation/devicetree/bindings/net/dsa/ksz.txt | 73 +++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/dsa/ksz.txt
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> new file mode 100644
> index 0000000..9cca7d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> @@ -0,0 +1,73 @@
> +Microchip KSZ Series Ethernet switches
> +==================================
> +
> +Required properties:
> +
> +- compatible: For external switch chips, compatible string must be exactly one
> + of: "microchip,ksz9477"
> +
> +See Documentation/devicetree/bindings/dsa/dsa.txt for a list of additional
> +required and optional properties.
> +
> +Examples:
> +
> +Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> +
> + eth0: ethernet@10001000 {
> + fixed-link {
> + reg = <7>
> + speed = <1000>;
> + duplex-full;
> + };
> + };
> +
> + spi1: spi@f8008000 {
> + pinctrl-0 = <&pinctrl_spi_ksz>;
> + cs-gpios = <&pioC 25 0>;
> + id = <1>;
> + status = "okay";
4 lines above should be indented more to the right.
> +
> + ksz9477: ksz9477@0 {
> + compatible = "microchip,ksz9477";
> + reg = <0>;
> +
> + spi-max-frequency = <44000000>;
> + spi-cpha;
> + spi-cpol;
> +
> + status = "okay";
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + label = "lan1";
> + };
> + port@1 {
> + reg = <1>;
> + label = "lan2";
> + };
> + port@2 {
> + reg = <2>;
> + label = "lan3";
> + };
> + port@3 {
> + reg = <3>;
> + label = "lan4";
> + };
> + port@4 {
> + reg = <4>;
> + label = "lan5";
> + };
> + port@5 {
> + reg = <5>;
> + label = "cpu";
> + ethernet = <&macb0>;
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> + };
> + };
> + };
Unmatched }?
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH net-next 4/5] dsa: Microchip KSZ switches SPI devicetree configuration
2017-05-06 10:02 ` Sergei Shtylyov
@ 2017-05-07 1:04 ` Woojung.Huh
0 siblings, 0 replies; 4+ messages in thread
From: Woojung.Huh @ 2017-05-07 1:04 UTC (permalink / raw)
To: sergei.shtylyov, andrew, f.fainelli, vivien.didelot
Cc: netdev, davem, UNGLinuxDriver
Hi Sergei
>> + spi1: spi@f8008000 {
>> + pinctrl-0 = <&pinctrl_spi_ksz>;
>> + cs-gpios = <&pioC 25 0>;
>> + id = <1>;
>> + status = "okay";
>
> 4 lines above should be indented more to the right.
>> + };
>> + };
>
> Unmatched }?
Will fix both.
- Woojung
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-07 22:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-05 23:18 [PATCH net-next 4/5] dsa: Microchip KSZ switches SPI devicetree configuration Woojung.Huh
2017-05-06 3:54 ` Andrew Lunn
2017-05-06 10:02 ` Sergei Shtylyov
2017-05-07 1:04 ` Woojung.Huh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).