From: Dan Jurgens <danielj@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, jasowang@redhat.com, pabeni@redhat.com,
virtualization@lists.linux.dev, parav@nvidia.com,
shshitrit@nvidia.com, yohadt@nvidia.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgg@ziepe.ca,
kevin.tian@intel.com, kuba@kernel.org, andrew+netdev@lunn.ch,
edumazet@google.com
Subject: Re: [PATCH net-next v16 06/12] virtio_net: Create a FF group for ethtool steering
Date: Thu, 29 Jan 2026 11:08:16 -0600 [thread overview]
Message-ID: <1aecc98e-8215-4fc7-97f6-e1247da60339@nvidia.com> (raw)
In-Reply-To: <20260122165014-mutt-send-email-mst@kernel.org>
On 1/22/26 3:51 PM, Michael S. Tsirkin wrote:
>> + ethtool_group.group_priority = cpu_to_le16(VIRTNET_FF_ETHTOOL_GROUP_PRIORITY);
>> +
>> + /* Use priority for the object ID. */
>> + err = virtio_admin_obj_create(vdev,
>> + VIRTIO_NET_RESOURCE_OBJ_FF_GROUP,
>> + VIRTNET_FF_ETHTOOL_GROUP_PRIORITY,
>
> This (3rd param to virtio_admin_obj_create)
> is the object ID actually. Setting this to 1 means it is outside
> of range for group limit which should be 0...limit - 1 and limit is 1.
>
> don't you mean 0?
>
No, the the maximum number of groups being 1 doesn't say anything about
the ID you use for that group. Higher IDs indicate higher priorities. I
intentionally choose 1 here because a reasonable follow on series would
be to implement ARFS. In that case it would make sense to have user
created rules higher priority than ARFS rules.
>
>> + VIRTIO_ADMIN_GROUP_TYPE_SELF,
next prev parent reply other threads:[~2026-01-29 17:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 22:06 [PATCH net-next v16 00/12] virtio_net: Add ethtool flow rules support Daniel Jurgens
2026-01-21 22:06 ` [PATCH net-next v16 01/12] virtio_pci: Remove supported_cap size build assert Daniel Jurgens
2026-01-21 22:06 ` [PATCH net-next v16 02/12] virtio: Add config_op for admin commands Daniel Jurgens
2026-01-21 22:06 ` [PATCH net-next v16 03/12] virtio: Expose generic device capability operations Daniel Jurgens
2026-01-22 17:32 ` Michael S. Tsirkin
2026-01-21 22:06 ` [PATCH net-next v16 04/12] virtio: Expose object create and destroy API Daniel Jurgens
2026-01-21 22:06 ` [PATCH net-next v16 05/12] virtio_net: Query and set flow filter caps Daniel Jurgens
2026-01-23 1:43 ` [net-next,v16,05/12] " Jakub Kicinski
2026-01-29 17:51 ` Dan Jurgens
2026-01-21 22:06 ` [PATCH net-next v16 06/12] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2026-01-22 21:51 ` Michael S. Tsirkin
2026-01-29 17:08 ` Dan Jurgens [this message]
2026-01-21 22:06 ` [PATCH net-next v16 07/12] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2026-01-23 1:45 ` [net-next,v16,07/12] " Jakub Kicinski
2026-01-21 22:06 ` [PATCH net-next v16 08/12] virtio_net: Use existing classifier if possible Daniel Jurgens
2026-01-21 22:06 ` [PATCH net-next v16 09/12] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2026-01-22 17:21 ` Michael S. Tsirkin
2026-01-29 18:46 ` Dan Jurgens
2026-01-21 22:06 ` [PATCH net-next v16 10/12] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2026-01-21 22:06 ` [PATCH net-next v16 11/12] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2026-01-21 22:06 ` [PATCH net-next v16 12/12] virtio_net: Add get ethtool flow rules ops Daniel Jurgens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aecc98e-8215-4fc7-97f6-e1247da60339@nvidia.com \
--to=danielj@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=shshitrit@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yohadt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox