Re: [PATCH v7 bpf-next 5/7] bpf: udp: Avoid socket skips and repeats during iteration

[Martin KaFai Lau <martin.lau@linux.dev>]

On 5/2/25 9:15 AM, Jordan Rife wrote:
>   static struct sock *bpf_iter_udp_batch(struct seq_file *seq)
>   {
>   	struct bpf_udp_iter_state *iter = seq->private;
>   	struct udp_iter_state *state = &iter->state;
> +	unsigned int find_cookie, end_cookie = 0;

A nit. I removed the zero initialization in the "end_cookie". Like 
"find_cookie", both of them will be initialized by iter->cur_sk and iter->end_sk 
later.

Applied. Thanks.

>   	struct net *net = seq_file_net(seq);
> -	int resume_bucket, resume_offset;
>   	struct udp_table *udptable;
>   	unsigned int batch_sks = 0;
> +	int resume_bucket;
>   	int resizes = 0;
>   	struct sock *sk;
>   	int err = 0;
>   
>   	resume_bucket = state->bucket;
> -	resume_offset = iter->offset;
>   
>   	/* The current batch is done, so advance the bucket. */
>   	if (iter->cur_sk == iter->end_sk)
> @@ -3434,6 +3452,8 @@ static struct sock *bpf_iter_udp_batch(struct seq_file *seq)
>   	 * before releasing the bucket lock. This allows BPF programs that are
>   	 * called in seq_show to acquire the bucket lock if needed.
>   	 */
> +	find_cookie = iter->cur_sk;
> +	end_cookie = iter->end_sk;
>   	iter->cur_sk = 0;
>   	iter->end_sk = 0;
>   	batch_sks = 0;