From: David Ahern <dsahern@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
kuniyu@amazon.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
yonghong.song@linux.dev, song@kernel.org, kernel-team@meta.com
Subject: Re: [PATCH net-next] udp: Add tracepoint for udp_sendmsg()
Date: Thu, 17 Apr 2025 21:57:56 -0700 [thread overview]
Message-ID: <1b17ce33-015f-4a10-9a98-ebea586c3ce4@kernel.org> (raw)
In-Reply-To: <aAElmpUWd6D7UBZY@gmail.com>
On 4/17/25 10:00 AM, Breno Leitao wrote:
>> $ git grep trace_ net drivers/net | grep _tp
>> net/bpf/test_run.c: trace_bpf_trigger_tp(nonce);
>> net/ipv4/tcp_input.c: trace_tcp_cwnd_reduction_tp(sk,
>> newly_acked_sacked, newly_lost, flag);
>
> Do we want to rename them and remove the _tp? I suppose it is OK given
> that tracepoints are not expected to be stable?
>
> Also, if we have consensus about this patch, I will remove the _tp from
> it.
>
I am only asking for consistency. Based on existing networking
instances, consistency is no _tp suffix.
next prev parent reply other threads:[~2025-04-18 4:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 19:23 [PATCH net-next] udp: Add tracepoint for udp_sendmsg() Breno Leitao
2025-04-16 19:34 ` Willem de Bruijn
2025-04-17 11:31 ` Breno Leitao
2025-04-17 13:38 ` Willem de Bruijn
2025-04-16 23:16 ` David Ahern
2025-04-17 11:42 ` Breno Leitao
2025-04-17 15:55 ` David Ahern
2025-04-17 16:00 ` Breno Leitao
2025-04-18 4:57 ` David Ahern [this message]
2025-04-18 12:33 ` Steven Rostedt
2025-04-18 14:47 ` Steven Rostedt
2025-04-17 6:57 ` Paolo Abeni
2025-04-17 11:34 ` Breno Leitao
2025-04-17 13:17 ` Paolo Abeni
2025-04-17 15:37 ` Song Liu
2025-04-17 15:48 ` Willem de Bruijn
2025-04-17 20:00 ` Song Liu
2025-04-18 14:49 ` Willem de Bruijn
2025-05-27 13:45 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b17ce33-015f-4a10-9a98-ebea586c3ce4@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).