From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416A0C5DF61 for ; Thu, 7 Nov 2019 14:31:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1865621D7B for ; Thu, 7 Nov 2019 14:31:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jV1JYaW0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389443AbfKGObR (ORCPT ); Thu, 7 Nov 2019 09:31:17 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:25640 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389379AbfKGObR (ORCPT ); Thu, 7 Nov 2019 09:31:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573137075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QrHdD94AcwG1Ax7bWiCTd//fNTx3IE4kMIx+0uxwiSM=; b=jV1JYaW0VsH7Gd4vmhJWhnK8LnielSO2GRGYcm0fak8Qt9+rRQcqVICU3Wa7d/Foh+uvIu oEGOlK96X7HQzoGjVyXsw3UtCLY6tVSNHMUf1fxHJea3WWO34FGW3zMHdApN6YuWA3mrlY HbGi4sf3B7QNxsic6ZRIlXI0jAexYns= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-SpgoB20dMl6mpmpHXbbyGA-1; Thu, 07 Nov 2019 09:31:10 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33BB0477; Thu, 7 Nov 2019 14:31:06 +0000 (UTC) Received: from [10.72.12.21] (ovpn-12-21.pek2.redhat.com [10.72.12.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id CBAAB5D6D8; Thu, 7 Nov 2019 14:30:39 +0000 (UTC) Subject: Re: [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework To: Alex Williamson , Randy Dunlap Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, mst@redhat.com, tiwei.bie@intel.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, cohuck@redhat.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, akrowiak@linux.ibm.com, freude@linux.ibm.com, lingshan.zhu@intel.com, idos@mellanox.com, eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com, christophe.de.dinechin@gmail.com, kevin.tian@intel.com, stefanha@redhat.com References: <20191106070548.18980-1-jasowang@redhat.com> <20191106070548.18980-7-jasowang@redhat.com> <88efad07-70aa-3879-31e7-ace4d2ad63a1@infradead.org> <20191106155800.0b8418ec@x1.home> From: Jason Wang Message-ID: <1b26d298-0223-c5cc-9dd6-c4005139e32a@redhat.com> Date: Thu, 7 Nov 2019 22:30:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191106155800.0b8418ec@x1.home> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: SpgoB20dMl6mpmpHXbbyGA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/11/7 =E4=B8=8A=E5=8D=886:58, Alex Williamson wrote: > On Wed, 6 Nov 2019 14:50:30 -0800 > Randy Dunlap wrote: > >> On 11/5/19 11:05 PM, Jason Wang wrote: >>> diff --git a/samples/Kconfig b/samples/Kconfig >>> index c8dacb4dda80..13a2443e18e0 100644 >>> --- a/samples/Kconfig >>> +++ b/samples/Kconfig >>> @@ -131,6 +131,16 @@ config SAMPLE_VFIO_MDEV_MDPY >>> =09 mediated device. It is a simple framebuffer and supports >>> =09 the region display interface (VFIO_GFX_PLANE_TYPE_REGION). >>> =20 >>> +config SAMPLE_VIRTIO_MDEV_NET >>> +=09tristate "Build VIRTIO net example mediated device sample code -- l= oadable modules only" >>> +=09depends on VIRTIO_MDEV && VHOST_RING && m >>> +=09help >>> +=09 Build a networking sample device for use as a virtio >>> +=09 mediated device. The device coopreates with virtio-mdev bus >> typo here: >> =09 cooperates >> > I can fix this on commit relative to V10 if there are no other issues > raised: > > diff --git a/samples/Kconfig b/samples/Kconfig > index 13a2443e18e0..b7116d97cbbe 100644 > --- a/samples/Kconfig > +++ b/samples/Kconfig > @@ -136,7 +136,7 @@ config SAMPLE_VIRTIO_MDEV_NET > depends on VIRTIO_MDEV && VHOST_RING && m > help > Build a networking sample device for use as a virtio > - mediated device. The device coopreates with virtio-mdev bus > + mediated device. The device cooperates with virtio-mdev bus > driver to present an virtio ethernet driver for > kernel. It simply loopbacks all packets from its TX > virtqueue to its RX virtqueue. > > Thanks, > Alex Thanks, per Michael request, I would rename mvnet and include this fix=20 in V11. >