From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A341258EE0 for ; Mon, 23 Mar 2026 15:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774278096; cv=none; b=c4GaaPj8+6a1TbwnCTa4FvGfixYqQ9gOz0bFcyWWI+SZjM2CGCygNlYW+wsrfFas3wKVqSZaBe+3sdCjWZhtAf1u++kvOBwXlUBv/OCXAaycLaNn62mW9uXyqUciFvQq0zEujVi1+GNJxiHr2OPsZslrvpS9JiZv4N4S2DoMMII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774278096; c=relaxed/simple; bh=YJAGFGGqTDdOapPqoyMIufJSNynlGJlzEAnVFZvT4oA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OGG3yM/ZznX7eGHbuhKhShyRrCDxJQZomB5HV7s3gpzzBEvLuwYTA+2nf7vUwzEXwxYA/ZCV0SFItwrvUK6p8twIEmcHfU4x24oyFoYyrAHF7bAFd8euh9dbf6w3ix2m+nJ7I3stGsuL/myGbdonYfMTp9G+RiFJtAuKw4p6x6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=ngzzRSRu; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="ngzzRSRu" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-40423dbe98bso1103093fac.2 for ; Mon, 23 Mar 2026 08:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1774278093; x=1774882893; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uOPOYS/nGpT6q8jY3dWvKs7qQBZ0laozgcfEFZVyZg8=; b=ngzzRSRuyM8B3sEkL1nkBwYw746zNpG1KVfpJREhN15HtNmX0w9trIFjMfkuANx+W/ JPP9bMj/Ufz2oNoguTJyfY1zGK4cU+C6Wku4qI3/3ZXsx5G7Ol2nTv8h0CDhW/x7FbcY 13j7fXR0WXHqW9IIHz4K9lB4wVGeuaeqvvmayFuL6Xioi3gmoTsGr08QatTiP8c6BkKT I6Dey+RWxOGSPKHFRhxkTOIBuRJHdD9owWxXQMFcD9vIy70RvcChG1k91KWJqCRNEH8g U1VV1ZNnOhEwL2vbXZJAC5Dm19rqmAofOYuoA1Uklkr3oekqDIC+dLWhEXVCN6sBlgaJ zg9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774278093; x=1774882893; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uOPOYS/nGpT6q8jY3dWvKs7qQBZ0laozgcfEFZVyZg8=; b=qiYRCEC0cZ2LOkNO4rs82l34Qa5iLmNX69cChF07nGhRQ+nTi42Pr5YYWvQeLGCXfN 8Vvj2/iVBuPMBvJoWkBeohq3wsqj38FwXmG7vspA48dsMQDYmDmFvoHCujEMjmYpGvqC Z3wtwQ6H87D2zXBMeFJMP1emUtGkbC4fZ9JDiaRE+9N8kMkSBWdaR6dh7jNoebdyPvXa +A7dmUJmIED8tAoDX3xMivwCauxwysXOyCHzSMY1NGENvwAnd6TncSLj5iAWwHWRsWrf qsTU6PbjCdjzl/zPpCQzLNaxP7BHtEJzzHIfYduEnaZ9bs0MoGlQcUfPjtLCMgYZX9j0 6Sdw== X-Gm-Message-State: AOJu0Yw20Bs5gJGvpqtJmtDoiFyMMEKRC7L0tMvUdUORKZRdoFfB1HbI +/VPTZh4oMAlNViJnBfr7whSXFfn5xxYz0Wuv4xCvCAxC0wNACY9tUBWtwTSzz/FDVU= X-Gm-Gg: ATEYQzwh9AqaH6cuEl+13U1uR3IOgEQ+vhAruESwNCflfOM0ntYPSxjjH1Ivs9l1jKD YbTmQJzyO913q+HhZgHEPLRMzOqFjwRUV/w2q3scPRE/i2b+nhKYDlIV41z5Jy558xTLDv0FqT6 mmiO6hiBqPwymvUhhFZTu57S0tIOzQfMMwu5dBplbqLRw2poAugnaeOPw1kbisGSOEsLuS5kO/B goGOfmkx/3vtzND4FkNbvAVfOc8JtCaL0/D5a7hWPHj3dxVFo2434gXzO+JO71zMv9q98Qcs/Zw z5ryGF/jFoJvco2v0AOVQlnio6XQIW27Y0sV61jbSGyf8pZy5I2h4OaNdTctfBJyKJXPeqcpgHB RE8y7B14TaUmYitZIQGV4pU+h4SU+YrSDZ9Y6mSod7cUkrgJ1m0KyHoO1/EKOanSKxpgx8DGTz4 ByqVTK1nQts7quJMe+mwZjSczsj5QtQ/vfybF6vtb2igEhqN+AE2Cy82sTt4CpfEqarv0sEr0Or N8/mIH5pg== X-Received: by 2002:a05:6870:28c:b0:417:5828:ed3 with SMTP id 586e51a60fabf-41c111f5247mr7123073fac.38.1774278092544; Mon, 23 Mar 2026 08:01:32 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-41c14ddbca8sm10822185fac.15.2026.03.23.08.01.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 08:01:31 -0700 (PDT) Message-ID: <1b3ad321-866a-4cb8-9810-5eae7805647d@kernel.dk> Date: Mon, 23 Mar 2026 09:01:30 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH io_uring-7.1 01/16] io_uring/zcrx: return back two step unregistration To: Pavel Begunkov , io-uring@vger.kernel.org Cc: netdev@vger.kernel.org, Youngmin Choi References: <0ce21f0565ab4358668922a28a8a36922dfebf76.1774261953.git.asml.silence@gmail.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <0ce21f0565ab4358668922a28a8a36922dfebf76.1774261953.git.asml.silence@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/23/26 6:43 AM, Pavel Begunkov wrote: > @@ -898,12 +933,15 @@ void io_unregister_zcrx_ifqs(struct io_ring_ctx *ctx) > unsigned long id = 0; > > ifq = xa_find(&ctx->zcrx_ctxs, &id, ULONG_MAX, XA_PRESENT); > - if (ifq) > + if (ifq) { > + if (WARN_ON_ONCE(!is_zcrx_entry_marked(ctx, id))) > + break; This break is inside the scoped_guard(), does this need an ifq = NULL here? I do like scoped locking, but this seems a bit tricky... -- Jens Axboe