From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH net 1/2] RDS: TCP: rds_tcp_accept_worker() must exit gracefully when terminating rds-tcp Date: Wed, 18 May 2016 11:33:19 -0700 Message-ID: <1b519ce2-89f2-3b98-e00b-73d453e1e53e@oracle.com> References: <73ccad462f8f54dfa9c71576c3f5d48ea2b1dc12.1463579486.git.sowmini.varadhan@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, rds-devel@oss.oracle.com, ajaykumar.hotchandani@oracle.com To: Sowmini Varadhan , netdev@vger.kernel.org Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:45711 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899AbcERSdk (ORCPT ); Wed, 18 May 2016 14:33:40 -0400 In-Reply-To: <73ccad462f8f54dfa9c71576c3f5d48ea2b1dc12.1463579486.git.sowmini.varadhan@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: On 5/18/2016 10:06 AM, Sowmini Varadhan wrote: > There are two instances where we want to terminate RDS-TCP: when > exiting the netns or during module unload. In either case, the > termination sequence is to stop the listen socket, mark the > rtn->rds_tcp_listen_sock as null, and flush any accept workqs. > Thus any workqs that get flushed at this point will encounter a > null rds_tcp_listen_sock, and must exit gracefully to allow > the RDS-TCP termination to complete successfully. > > Signed-off-by: Sowmini Varadhan > --- > net/rds/tcp_listen.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c > index be263cd..e10b422 100644 > --- a/net/rds/tcp_listen.c > +++ b/net/rds/tcp_listen.c > @@ -80,6 +80,9 @@ int rds_tcp_accept_one(struct socket *sock) > int conn_state; > struct sock *nsk; > > + if (!sock) /* module unload or netns delete in progress */ > + return -ENETUNREACH; > + New error code type in RDS but seems appropriate :-) Patch looks good to me. Acked-by: Santosh Shilimkar