From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: "Michael Büsch" <m@bues.ch>, "Priit Laes" <plaes@plaes.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Kalle Valo <kvalo@codeaurora.org>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH v2 3/3] b43: Use cordic algorithm from kernel library
Date: Mon, 5 Nov 2018 23:11:17 +0100 [thread overview]
Message-ID: <1b536f41-6bda-712b-cd57-0034f924992a@broadcom.com> (raw)
In-Reply-To: <20181105223909.61860cdd@wiggum>
On 11/5/2018 10:39 PM, Michael Büsch wrote:
> On Mon, 5 Nov 2018 21:37:18 +0200
> Priit Laes <plaes@plaes.org> wrote:
>
>> Kernel library has a common cordic algorithm which is identical
>> to internally implementatd one, so use it and drop the duplicate
>> implementation.
>>
>> Signed-off-by: Priit Laes <plaes@plaes.org>
>
>
> This looks nice.
> But what is the testing status of this?
> Has this been tested on actual b43-LP hardware?
>
> Is the replacement algorithm exactly the same, or are there slight
> differences (e.g. in corner cases)?
Hi Michael,
I recall doing a comparison between the algorithms and thought I put
that in the original commit message. However, it is not there. It is not
exactly the same as in b43 so there are difference for certain angles,
most results are the same however. This implementation is slightly more
accurate on the full scale.
prev parent reply other threads:[~2018-11-05 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.9ec98292c595a111ae78f31383ff8618c9cb04da.1541446422.git-series.plaes@plaes.org>
2018-11-05 19:37 ` [PATCH v2 2/3] brcmsmac: Use cordic-related macros from common cordic library Priit Laes
2018-11-05 19:37 ` [PATCH v2 3/3] b43: Use cordic algorithm from kernel library Priit Laes
2018-11-05 21:39 ` Michael Büsch
2018-11-05 22:11 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b536f41-6bda-712b-cd57-0034f924992a@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=netdev@vger.kernel.org \
--cc=plaes@plaes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox