From: Krzysztof Kozlowski <krzk@kernel.org>
To: weishangjuan@eswincomputing.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
vladimir.oltean@nxp.com, rmk+kernel@armlinux.org.uk,
yong.liang.choong@linux.intel.com,
prabhakar.mahadev-lad.rj@bp.renesas.com, inochiama@gmail.com,
jan.petrous@oss.nxp.com, jszhang@kernel.org,
p.zabel@pengutronix.de, 0x1207@gmail.com,
boon.khai.ng@altera.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
lizhi2@eswincomputing.com
Subject: Re: [PATCH v2 2/2] ethernet: eswin: Add eic7700 ethernet driver
Date: Wed, 28 May 2025 07:50:20 +0200 [thread overview]
Message-ID: <1b975a3e-ae1c-4354-90db-1f8d7ff567d3@kernel.org> (raw)
In-Reply-To: <20250528041634.912-1-weishangjuan@eswincomputing.com>
On 28/05/2025 06:16, weishangjuan@eswincomputing.com wrote:
> +static int eswin_qos_probe(struct platform_device *pdev,
> + struct plat_stmmacenet_data *plat_dat,
> + struct stmmac_resources *stmmac_res)
> +{
> + struct eswin_qos_priv *dwc_priv;
> + u32 hsp_aclk_ctrl_offset;
> + u32 hsp_aclk_ctrl_regset;
> + u32 hsp_cfg_ctrl_offset;
> + u32 eth_axi_lp_ctrl_offset;
> + u32 eth_phy_ctrl_offset;
> + u32 eth_phy_ctrl_regset;
> + struct clk *clk_app;
> + int ret;
> + int err;
> +
> + dwc_priv = devm_kzalloc(&pdev->dev, sizeof(*dwc_priv), GFP_KERNEL);
> + if (!dwc_priv)
> + return -ENOMEM;
> +
> + if (device_property_read_u32(&pdev->dev, "id", &dwc_priv->dev_id))
NAK, you cannot have undocumented ABI. You did not test your DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-28 5:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 4:14 [PATCH v2 0/2] Add driver support for Eswin eic7700 SoC ethernet controller weishangjuan
2025-05-28 4:15 ` [PATCH v2 1/2] dt-bindings: ethernet: eswin: Document for EIC7700 SoC weishangjuan
2025-05-28 5:21 ` Rob Herring (Arm)
2025-05-28 5:48 ` Krzysztof Kozlowski
2025-05-28 13:34 ` Andrew Lunn
2025-05-28 4:16 ` [PATCH v2 2/2] ethernet: eswin: Add eic7700 ethernet driver weishangjuan
2025-05-28 5:50 ` Krzysztof Kozlowski [this message]
2025-07-15 10:09 ` Re: [PATCH v3 " 李志
2025-05-28 13:44 ` [PATCH v2 " Andrew Lunn
2025-05-28 14:32 ` Russell King (Oracle)
2025-05-28 18:37 ` kernel test robot
2025-05-28 5:24 ` [PATCH v2 0/2] Add driver support for Eswin eic7700 SoC ethernet controller Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b975a3e-ae1c-4354-90db-1f8d7ff567d3@kernel.org \
--to=krzk@kernel.org \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=inochiama@gmail.com \
--cc=jan.petrous@oss.nxp.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lizhi2@eswincomputing.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=weishangjuan@eswincomputing.com \
--cc=yong.liang.choong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).