public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Edward Cree <ecree.xilinx@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>,
	Salvatore Bonaccorso <carnil@debian.org>,
	linux-net-drivers@amd.com
Cc: 1126015@bugs.debian.org,
	Damir Mansurov <damir.mansurov@oktetlabs.ru>,
	netdev <netdev@vger.kernel.org>
Subject: Re: Bug#1126015: linux-image-6.17.13+deb14-rt-amd64: ethtool -x <sfc-net-driver-ifname> causes: rtmutex deadlock detected
Date: Thu, 22 Jan 2026 20:11:53 +0000	[thread overview]
Message-ID: <1bb7607e-b078-4e30-bae3-9d9a8ab627f2@gmail.com> (raw)
In-Reply-To: <e4dcf5497e3840706b2e13d10c7efff1819c14a6.camel@decadent.org.uk>

On 21/01/2026 12:39, Ben Hutchings wrote:
> The deadlock seems to be quite straightforward:
> 
> 1. In net/ethtool/rss.c, rss_prepare_get() locks the net device's
>    rss_lock and calls its driver's get_rxfh operation
> 2. In drivers/net/ethernet/sfc/ethtool_common.c, efx_ethtool_get_rxfh()
>    calls the chip's rx_pull_rss_config operation
> 3. In drivers/net/ethernet/sfc/mcdi_filters.c,
>    efx_mcdi_rx_pull_rss_config() locks the net device's rss_lock
> 
> Step 3 seems to be a workaround for missing locking in the ethtool core.
> Since that locking was added to the ethtool core in 6.17, it needs to be
> removed from the sfc driver from that version onward.

Analysis looks correct to me.  I think the appropriate Fixes tag is
040cef30b5e6 ("net: ethtool: move get_rxfh callback under the rss_lock")

Unless you want to do it, I'll post a patch with Damir's Reported-by:
 and your Suggested-by:.

-ed

      reply	other threads:[~2026-01-22 20:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <176891113233.1085.14440184213728685693.reportbug@elrond.oktetlabs.ru>
     [not found] ` <aXBdvYZIePCFGtY9@eldamar.lan>
2026-01-21 12:39   ` Bug#1126015: linux-image-6.17.13+deb14-rt-amd64: ethtool -x <sfc-net-driver-ifname> causes: rtmutex deadlock detected Ben Hutchings
2026-01-22 20:11     ` Edward Cree [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bb7607e-b078-4e30-bae3-9d9a8ab627f2@gmail.com \
    --to=ecree.xilinx@gmail.com \
    --cc=1126015@bugs.debian.org \
    --cc=ben@decadent.org.uk \
    --cc=carnil@debian.org \
    --cc=damir.mansurov@oktetlabs.ru \
    --cc=linux-net-drivers@amd.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox