From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH net] net: broadcom: bcm4908_enet: fix RX path possible mem leak
Date: Wed, 24 Feb 2021 09:05:10 -0800 [thread overview]
Message-ID: <1bc6b65e-fa63-8dee-426e-c4cdbaab697c@gmail.com> (raw)
In-Reply-To: <20210224151842.2419-1-zajec5@gmail.com>
On 2/24/2021 7:18 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> After filling RX ring slot with new skb it's required to free old skb.
> Immediately on error or later in the net subsystem.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: 4feffeadbcb2 ("net: broadcom: bcm4908enet: add BCM4908 controller
driver")
--
Florian
prev parent reply other threads:[~2021-02-24 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 15:18 [PATCH net] net: broadcom: bcm4908_enet: fix RX path possible mem leak Rafał Miłecki
2021-02-24 15:18 ` [PATCH net] net: broadcom: bcm4908_enet: fix NAPI poll returned value Rafał Miłecki
2021-02-24 17:06 ` Florian Fainelli
2021-02-25 17:48 ` Jakub Kicinski
2021-02-24 17:05 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bc6b65e-fa63-8dee-426e-c4cdbaab697c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).