From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D7EAC433E0 for ; Wed, 24 Feb 2021 17:06:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C510364F03 for ; Wed, 24 Feb 2021 17:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236100AbhBXRGn (ORCPT ); Wed, 24 Feb 2021 12:06:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236006AbhBXRFz (ORCPT ); Wed, 24 Feb 2021 12:05:55 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D06FC06174A for ; Wed, 24 Feb 2021 09:05:14 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id l18so1738212pji.3 for ; Wed, 24 Feb 2021 09:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jXe4eoOUt1Iw+Kyc8T6LgYJD4gfmsOg9wn2gGSl3w/A=; b=eQOK0X8jkjVqbrioivA4cUZM2YfBD80jBxhlGmH8JSvNcZg0j/AqJxizEkoI0Db94J QqBsDFTKbYADD3sc0TxlzT1qAWGDMtup2x3c9GsoIfTocYsmQ+5xTwj58YrpuLg9o9QK DTc8M89smNuwr6Wqv6bPcE1tSMgPao35oxSR/bJczznDk6O8OUrXJETk+Fp0WoR1iOQ/ VOhaHPTV/uTujA/5x7RoCjPYvp4KTH7XQVX5G1tccaOX9jUxXjPOAXN3pT1tlxBD2jpE AXHxeXo/IrCn03L4FIfUApzMgzsBDsPasQcK2oLcQ7lVlgq0GJ02fJ2TEgLBgzuTKTQn 1/JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jXe4eoOUt1Iw+Kyc8T6LgYJD4gfmsOg9wn2gGSl3w/A=; b=B5bk8tKJTmoWJftPSEek92NoIBak4WUTl99cBcItGT7LT9hz6/L5227Z/aop7PxeoK YMKhs7kKm0gw5kuK2629IIZEHgaW+uaLsX7lyqg56ySqfCU3Po+qcAOlvSySfbeWl47D EyO8hvcR6Yc4jXFoNrD4T+/ufGqdJB1iKht4Zn3faEQlgNK/PPzMjl37sXxZfk+/5KXO iKivOdGOJ/92dBBGwUT4TL3ewgTJfuEGJuyzr5hXO7B0Tu3FIio+TQoUBDjCDm/5GFOQ quTkiXt3sEWVBbH1yo01t6+IvDC10AQC9+rw6tEioIRPhOhDmj38SjqHiMKmHwbl2MdT arLQ== X-Gm-Message-State: AOAM533KaTiNyJptVb6bllFTY2Hqm2e6iV/UI7EfUiPQ8o5f4NHWV29Q ejOpde8PwKbZj7grzs40tiA= X-Google-Smtp-Source: ABdhPJz3QDwz5brGzV3dHN4/FRpeRpNk5dv46JsxqDpJPhqTfBDFSIy8+TISsvEH8VGtUQ7o2OOmoA== X-Received: by 2002:a17:90a:1f86:: with SMTP id x6mr5297955pja.135.1614186313997; Wed, 24 Feb 2021 09:05:13 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y20sm3343414pfo.210.2021.02.24.09.05.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 09:05:13 -0800 (PST) Subject: Re: [PATCH net] net: broadcom: bcm4908_enet: fix RX path possible mem leak To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20210224151842.2419-1-zajec5@gmail.com> From: Florian Fainelli Message-ID: <1bc6b65e-fa63-8dee-426e-c4cdbaab697c@gmail.com> Date: Wed, 24 Feb 2021 09:05:10 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210224151842.2419-1-zajec5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/24/2021 7:18 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > After filling RX ring slot with new skb it's required to free old skb. > Immediately on error or later in the net subsystem. > > Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli Fixes: 4feffeadbcb2 ("net: broadcom: bcm4908enet: add BCM4908 controller driver") -- Florian