From: "Kumar, M Chetan" <m.chetan.kumar@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
m.chetan.kumar@intel.com
Cc: Netdev <netdev@vger.kernel.org>,
kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net,
ryazanov.s.a@gmail.com, loic.poulain@linaro.org,
krishna.c.sudi@intel.com, linuxwwan@intel.com,
Haijun Liu <haijun.liu@mediatek.com>,
Madhusmita Sahu <madhusmita.sahu@intel.com>,
Ricardo Martinez <ricardo.martinez@linux.intel.com>,
Devegowda Chandrashekar <chandrashekar.devegowda@intel.com>
Subject: Re: [PATCH net-next 2/5] net: wwan: t7xx: Infrastructure for early port configuration
Date: Wed, 17 Aug 2022 21:53:39 +0530 [thread overview]
Message-ID: <1bc73cf7-38d2-e30e-5d68-4a63a9186fd0@linux.intel.com> (raw)
In-Reply-To: <5a74770-94d3-f690-4aa1-59cdbbb29339@linux.intel.com>
On 8/17/2022 5:40 PM, Ilpo Järvinen wrote:
> On Tue, 16 Aug 2022, m.chetan.kumar@intel.com wrote:
>
>> From: Haijun Liu <haijun.liu@mediatek.com>
>>
<skip>
>> @@ -372,7 +435,8 @@ static int t7xx_port_proxy_recv_skb(struct cldma_queue *queue, struct sk_buff *s
>>
>> seq_num = t7xx_port_next_rx_seq_num(port, ccci_h);
>> port_conf = port->port_conf;
>> - skb_pull(skb, sizeof(*ccci_h));
>> + if (!port->port_conf->is_early_port)
>> + skb_pull(skb, sizeof(*ccci_h));
>
> This seems to be the only user for is_early_port, wouldn't be more obvious
> to store the header size instead?
Early port doesn't carry header.
If we change it to header size, skb_pull() operators on zero length. OR
may need another such flag to bypass it.
--
Chetan
next prev parent reply other threads:[~2022-08-17 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 4:23 [PATCH net-next 2/5] net: wwan: t7xx: Infrastructure for early port configuration m.chetan.kumar
2022-08-17 12:10 ` Ilpo Järvinen
2022-08-17 15:15 ` Kumar, M Chetan
2022-08-18 10:48 ` Ilpo Järvinen
2022-08-19 9:26 ` Kumar, M Chetan
2022-08-19 22:33 ` Jakub Kicinski
2022-08-17 16:23 ` Kumar, M Chetan [this message]
2022-08-18 10:51 ` Ilpo Järvinen
2022-08-18 11:26 ` Kumar, M Chetan
2022-08-18 16:15 ` Jakub Kicinski
2022-08-30 1:59 ` Sergey Ryazanov
2022-08-31 12:47 ` Kumar, M Chetan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bc73cf7-38d2-e30e-5d68-4a63a9186fd0@linux.intel.com \
--to=m.chetan.kumar@linux.intel.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=davem@davemloft.net \
--cc=haijun.liu@mediatek.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=krishna.c.sudi@intel.com \
--cc=kuba@kernel.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@intel.com \
--cc=madhusmita.sahu@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).