* [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset
@ 2018-09-30 6:44 Maciej Żenczykowski
2018-09-30 6:44 ` [PATCH v2 2/9] net: inet_rtm_getroute() " Maciej Żenczykowski
` (9 more replies)
0 siblings, 10 replies; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-09-30 6:44 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev, David Ahern
From: Maciej Żenczykowski <maze@google.com>
(allows for better compiler optimization)
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
net/ipv4/route.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index dce2ed66ebe1..02482b71498b 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1217,18 +1217,15 @@ void ip_rt_get_source(u8 *addr, struct sk_buff *skb, struct rtable *rt)
src = ip_hdr(skb)->saddr;
else {
struct fib_result res;
- struct flowi4 fl4;
- struct iphdr *iph;
-
- iph = ip_hdr(skb);
-
- memset(&fl4, 0, sizeof(fl4));
- fl4.daddr = iph->daddr;
- fl4.saddr = iph->saddr;
- fl4.flowi4_tos = RT_TOS(iph->tos);
- fl4.flowi4_oif = rt->dst.dev->ifindex;
- fl4.flowi4_iif = skb->dev->ifindex;
- fl4.flowi4_mark = skb->mark;
+ struct iphdr *iph = ip_hdr(skb);
+ struct flowi4 fl4 = {
+ .daddr = iph->daddr,
+ .saddr = iph->saddr,
+ .flowi4_tos = RT_TOS(iph->tos),
+ .flowi4_oif = rt->dst.dev->ifindex,
+ .flowi4_iif = skb->dev->ifindex,
+ .flowi4_mark = skb->mark,
+ };
rcu_read_lock();
if (fib_lookup(dev_net(rt->dst.dev), &fl4, &res, 0) == 0)
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 2/9] net: inet_rtm_getroute() - use new style struct initializer instead of memset
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
@ 2018-09-30 6:44 ` Maciej Żenczykowski
2018-10-01 15:25 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 3/9] net: ip6_redirect() " Maciej Żenczykowski
` (8 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-09-30 6:44 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev, David Ahern
From: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
net/ipv4/route.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 02482b71498b..048919713f4e 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -2780,7 +2780,7 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,
struct rtable *rt = NULL;
struct sk_buff *skb;
struct rtmsg *rtm;
- struct flowi4 fl4;
+ struct flowi4 fl4 = {};
__be32 dst = 0;
__be32 src = 0;
kuid_t uid;
@@ -2820,7 +2820,6 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,
if (!skb)
return -ENOBUFS;
- memset(&fl4, 0, sizeof(fl4));
fl4.daddr = dst;
fl4.saddr = src;
fl4.flowi4_tos = rtm->rtm_tos;
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 3/9] net: ip6_redirect() - use new style struct initializer instead of memset
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
2018-09-30 6:44 ` [PATCH v2 2/9] net: inet_rtm_getroute() " Maciej Żenczykowski
@ 2018-09-30 6:44 ` Maciej Żenczykowski
2018-10-01 15:22 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 4/9] net: ip6_redirect_no_header() " Maciej Żenczykowski
` (7 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-09-30 6:44 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev, David Ahern
From: Maciej Żenczykowski <maze@google.com>
(allows for better compiler optimization)
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
net/ipv6/route.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index d28f83e01593..6f252fa914c2 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2508,16 +2508,15 @@ void ip6_redirect(struct sk_buff *skb, struct net *net, int oif, u32 mark,
{
const struct ipv6hdr *iph = (struct ipv6hdr *) skb->data;
struct dst_entry *dst;
- struct flowi6 fl6;
-
- memset(&fl6, 0, sizeof(fl6));
- fl6.flowi6_iif = LOOPBACK_IFINDEX;
- fl6.flowi6_oif = oif;
- fl6.flowi6_mark = mark;
- fl6.daddr = iph->daddr;
- fl6.saddr = iph->saddr;
- fl6.flowlabel = ip6_flowinfo(iph);
- fl6.flowi6_uid = uid;
+ struct flowi6 fl6 = {
+ .flowi6_iif = LOOPBACK_IFINDEX,
+ .flowi6_oif = oif,
+ .flowi6_mark = mark,
+ .daddr = iph->daddr,
+ .saddr = iph->saddr,
+ .flowlabel = ip6_flowinfo(iph),
+ .flowi6_uid = uid,
+ };
dst = ip6_route_redirect(net, &fl6, skb, &ipv6_hdr(skb)->saddr);
rt6_do_redirect(dst, NULL, skb);
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 4/9] net: ip6_redirect_no_header() - use new style struct initializer instead of memset
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
2018-09-30 6:44 ` [PATCH v2 2/9] net: inet_rtm_getroute() " Maciej Żenczykowski
2018-09-30 6:44 ` [PATCH v2 3/9] net: ip6_redirect() " Maciej Żenczykowski
@ 2018-09-30 6:44 ` Maciej Żenczykowski
2018-10-01 15:22 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 5/9] net: remove 1 always zero parameter from ip6_redirect_no_header() Maciej Żenczykowski
` (6 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-09-30 6:44 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev, David Ahern
From: Maciej Żenczykowski <maze@google.com>
(allows for better compiler optimization)
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
net/ipv6/route.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 6f252fa914c2..dff80697c033 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2530,15 +2530,14 @@ void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif,
const struct ipv6hdr *iph = ipv6_hdr(skb);
const struct rd_msg *msg = (struct rd_msg *)icmp6_hdr(skb);
struct dst_entry *dst;
- struct flowi6 fl6;
-
- memset(&fl6, 0, sizeof(fl6));
- fl6.flowi6_iif = LOOPBACK_IFINDEX;
- fl6.flowi6_oif = oif;
- fl6.flowi6_mark = mark;
- fl6.daddr = msg->dest;
- fl6.saddr = iph->daddr;
- fl6.flowi6_uid = sock_net_uid(net, NULL);
+ struct flowi6 fl6 = {
+ .flowi6_iif = LOOPBACK_IFINDEX,
+ .flowi6_oif = oif,
+ .flowi6_mark = mark,
+ .daddr = msg->dest,
+ .saddr = iph->daddr,
+ .flowi6_uid = sock_net_uid(net, NULL),
+ };
dst = ip6_route_redirect(net, &fl6, skb, &iph->saddr);
rt6_do_redirect(dst, NULL, skb);
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 5/9] net: remove 1 always zero parameter from ip6_redirect_no_header()
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
` (2 preceding siblings ...)
2018-09-30 6:44 ` [PATCH v2 4/9] net: ip6_redirect_no_header() " Maciej Żenczykowski
@ 2018-09-30 6:44 ` Maciej Żenczykowski
2018-10-01 15:23 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 6/9] net: ip6_update_pmtu() - use new style struct initializer instead of memset Maciej Żenczykowski
` (5 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-09-30 6:44 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev, David Ahern
From: Maciej Żenczykowski <maze@google.com>
(the parameter in question is mark)
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
include/net/ip6_route.h | 3 +--
net/ipv6/ndisc.c | 2 +-
net/ipv6/route.c | 4 +---
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h
index 7b9c82de11cc..cef186dbd2ce 100644
--- a/include/net/ip6_route.h
+++ b/include/net/ip6_route.h
@@ -165,8 +165,7 @@ void ip6_update_pmtu(struct sk_buff *skb, struct net *net, __be32 mtu, int oif,
void ip6_sk_update_pmtu(struct sk_buff *skb, struct sock *sk, __be32 mtu);
void ip6_redirect(struct sk_buff *skb, struct net *net, int oif, u32 mark,
kuid_t uid);
-void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif,
- u32 mark);
+void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif);
void ip6_sk_redirect(struct sk_buff *skb, struct sock *sk);
struct netlink_callback;
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 0ec273997d1d..51863ada15a4 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1533,7 +1533,7 @@ static void ndisc_redirect_rcv(struct sk_buff *skb)
if (!ndopts.nd_opts_rh) {
ip6_redirect_no_header(skb, dev_net(skb->dev),
- skb->dev->ifindex, 0);
+ skb->dev->ifindex);
return;
}
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index dff80697c033..e50525a95a09 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2524,8 +2524,7 @@ void ip6_redirect(struct sk_buff *skb, struct net *net, int oif, u32 mark,
}
EXPORT_SYMBOL_GPL(ip6_redirect);
-void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif,
- u32 mark)
+void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif)
{
const struct ipv6hdr *iph = ipv6_hdr(skb);
const struct rd_msg *msg = (struct rd_msg *)icmp6_hdr(skb);
@@ -2533,7 +2532,6 @@ void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif,
struct flowi6 fl6 = {
.flowi6_iif = LOOPBACK_IFINDEX,
.flowi6_oif = oif,
- .flowi6_mark = mark,
.daddr = msg->dest,
.saddr = iph->daddr,
.flowi6_uid = sock_net_uid(net, NULL),
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 6/9] net: ip6_update_pmtu() - use new style struct initializer instead of memset
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
` (3 preceding siblings ...)
2018-09-30 6:44 ` [PATCH v2 5/9] net: remove 1 always zero parameter from ip6_redirect_no_header() Maciej Żenczykowski
@ 2018-09-30 6:44 ` Maciej Żenczykowski
2018-10-01 15:24 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 7/9] net: rtmsg_to_fib6_config() " Maciej Żenczykowski
` (4 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-09-30 6:44 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev, David Ahern
From: Maciej Żenczykowski <maze@google.com>
(allows for better compiler optimization)
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
net/ipv6/route.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index e50525a95a09..dd19cf8dbcc1 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2349,15 +2349,14 @@ void ip6_update_pmtu(struct sk_buff *skb, struct net *net, __be32 mtu,
{
const struct ipv6hdr *iph = (struct ipv6hdr *) skb->data;
struct dst_entry *dst;
- struct flowi6 fl6;
-
- memset(&fl6, 0, sizeof(fl6));
- fl6.flowi6_oif = oif;
- fl6.flowi6_mark = mark ? mark : IP6_REPLY_MARK(net, skb->mark);
- fl6.daddr = iph->daddr;
- fl6.saddr = iph->saddr;
- fl6.flowlabel = ip6_flowinfo(iph);
- fl6.flowi6_uid = uid;
+ struct flowi6 fl6 = {
+ .flowi6_oif = oif,
+ .flowi6_mark = mark ? mark : IP6_REPLY_MARK(net, skb->mark),
+ .daddr = iph->daddr,
+ .saddr = iph->saddr,
+ .flowlabel = ip6_flowinfo(iph),
+ .flowi6_uid = uid,
+ };
dst = ip6_route_output(net, NULL, &fl6);
if (!dst->error)
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 7/9] net: rtmsg_to_fib6_config() - use new style struct initializer instead of memset
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
` (4 preceding siblings ...)
2018-09-30 6:44 ` [PATCH v2 6/9] net: ip6_update_pmtu() - use new style struct initializer instead of memset Maciej Żenczykowski
@ 2018-09-30 6:44 ` Maciej Żenczykowski
2018-10-01 15:36 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 8/9] net: rtm_to_fib6_config() " Maciej Żenczykowski
` (3 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-09-30 6:44 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev, David Ahern
From: Maciej Żenczykowski <maze@google.com>
(allows for better compiler optimization)
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
net/ipv6/route.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index dd19cf8dbcc1..c312ad4046d1 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3604,23 +3604,23 @@ static void rtmsg_to_fib6_config(struct net *net,
struct in6_rtmsg *rtmsg,
struct fib6_config *cfg)
{
- memset(cfg, 0, sizeof(*cfg));
+ *cfg = (struct fib6_config){
+ .fc_table = l3mdev_fib_table_by_index(net, rtmsg->rtmsg_ifindex) ?
+ : RT6_TABLE_MAIN,
+ .fc_ifindex = rtmsg->rtmsg_ifindex,
+ .fc_metric = rtmsg->rtmsg_metric,
+ .fc_expires = rtmsg->rtmsg_info,
+ .fc_dst_len = rtmsg->rtmsg_dst_len,
+ .fc_src_len = rtmsg->rtmsg_src_len,
+ .fc_flags = rtmsg->rtmsg_flags,
+ .fc_type = rtmsg->rtmsg_type,
+
+ .fc_nlinfo.nl_net = net,
- cfg->fc_table = l3mdev_fib_table_by_index(net, rtmsg->rtmsg_ifindex) ?
- : RT6_TABLE_MAIN;
- cfg->fc_ifindex = rtmsg->rtmsg_ifindex;
- cfg->fc_metric = rtmsg->rtmsg_metric;
- cfg->fc_expires = rtmsg->rtmsg_info;
- cfg->fc_dst_len = rtmsg->rtmsg_dst_len;
- cfg->fc_src_len = rtmsg->rtmsg_src_len;
- cfg->fc_flags = rtmsg->rtmsg_flags;
- cfg->fc_type = rtmsg->rtmsg_type;
-
- cfg->fc_nlinfo.nl_net = net;
-
- cfg->fc_dst = rtmsg->rtmsg_dst;
- cfg->fc_src = rtmsg->rtmsg_src;
- cfg->fc_gateway = rtmsg->rtmsg_gateway;
+ .fc_dst = rtmsg->rtmsg_dst,
+ .fc_src = rtmsg->rtmsg_src,
+ .fc_gateway = rtmsg->rtmsg_gateway,
+ };
}
int ipv6_route_ioctl(struct net *net, unsigned int cmd, void __user *arg)
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 8/9] net: rtm_to_fib6_config() - use new style struct initializer instead of memset
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
` (5 preceding siblings ...)
2018-09-30 6:44 ` [PATCH v2 7/9] net: rtmsg_to_fib6_config() " Maciej Żenczykowski
@ 2018-09-30 6:44 ` Maciej Żenczykowski
2018-10-01 15:35 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 9/9] net: inet6_rtm_getroute() " Maciej Żenczykowski
` (2 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-09-30 6:44 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev, David Ahern
From: Maciej Żenczykowski <maze@google.com>
(allows for better compiler optimization)
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
net/ipv6/route.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index c312ad4046d1..be5f7a15bc38 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -4143,14 +4143,19 @@ static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh,
err = -EINVAL;
rtm = nlmsg_data(nlh);
- memset(cfg, 0, sizeof(*cfg));
- cfg->fc_table = rtm->rtm_table;
- cfg->fc_dst_len = rtm->rtm_dst_len;
- cfg->fc_src_len = rtm->rtm_src_len;
- cfg->fc_flags = RTF_UP;
- cfg->fc_protocol = rtm->rtm_protocol;
- cfg->fc_type = rtm->rtm_type;
+ *cfg = (struct fib6_config){
+ .fc_table = rtm->rtm_table,
+ .fc_dst_len = rtm->rtm_dst_len,
+ .fc_src_len = rtm->rtm_src_len,
+ .fc_flags = RTF_UP,
+ .fc_protocol = rtm->rtm_protocol,
+ .fc_type = rtm->rtm_type,
+
+ .fc_nlinfo.portid = NETLINK_CB(skb).portid,
+ .fc_nlinfo.nlh = nlh,
+ .fc_nlinfo.nl_net = sock_net(skb->sk),
+ };
if (rtm->rtm_type == RTN_UNREACHABLE ||
rtm->rtm_type == RTN_BLACKHOLE ||
@@ -4166,10 +4171,6 @@ static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh,
cfg->fc_flags |= (rtm->rtm_flags & RTNH_F_ONLINK);
- cfg->fc_nlinfo.portid = NETLINK_CB(skb).portid;
- cfg->fc_nlinfo.nlh = nlh;
- cfg->fc_nlinfo.nl_net = sock_net(skb->sk);
-
if (tb[RTA_GATEWAY]) {
cfg->fc_gateway = nla_get_in6_addr(tb[RTA_GATEWAY]);
cfg->fc_flags |= RTF_GATEWAY;
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 9/9] net: inet6_rtm_getroute() - use new style struct initializer instead of memset
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
` (6 preceding siblings ...)
2018-09-30 6:44 ` [PATCH v2 8/9] net: rtm_to_fib6_config() " Maciej Żenczykowski
@ 2018-09-30 6:44 ` Maciej Żenczykowski
2018-10-01 15:26 ` David Ahern
2018-10-01 15:20 ` [PATCH v2 1/9] net: ip_rt_get_source() " David Ahern
2018-10-02 23:13 ` David Miller
9 siblings, 1 reply; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-09-30 6:44 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev, David Ahern
From: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
net/ipv6/route.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index be5f7a15bc38..6311a7fc5f63 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -4823,7 +4823,7 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,
struct rt6_info *rt;
struct sk_buff *skb;
struct rtmsg *rtm;
- struct flowi6 fl6;
+ struct flowi6 fl6 = {};
bool fibmatch;
err = nlmsg_parse(nlh, sizeof(*rtm), tb, RTA_MAX, rtm_ipv6_policy,
@@ -4832,7 +4832,6 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,
goto errout;
err = -EINVAL;
- memset(&fl6, 0, sizeof(fl6));
rtm = nlmsg_data(nlh);
fl6.flowlabel = ip6_make_flowinfo(rtm->rtm_tos, 0);
fibmatch = !!(rtm->rtm_flags & RTM_F_FIB_MATCH);
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
` (7 preceding siblings ...)
2018-09-30 6:44 ` [PATCH v2 9/9] net: inet6_rtm_getroute() " Maciej Żenczykowski
@ 2018-10-01 15:20 ` David Ahern
2018-10-02 23:13 ` David Miller
9 siblings, 0 replies; 21+ messages in thread
From: David Ahern @ 2018-10-01 15:20 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller; +Cc: netdev
On 9/30/18 12:44 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> (allows for better compiler optimization)
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> net/ipv4/route.c | 21 +++++++++------------
> 1 file changed, 9 insertions(+), 12 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/9] net: ip6_redirect() - use new style struct initializer instead of memset
2018-09-30 6:44 ` [PATCH v2 3/9] net: ip6_redirect() " Maciej Żenczykowski
@ 2018-10-01 15:22 ` David Ahern
0 siblings, 0 replies; 21+ messages in thread
From: David Ahern @ 2018-10-01 15:22 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller; +Cc: netdev
On 9/30/18 12:44 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> (allows for better compiler optimization)
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> net/ipv6/route.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 4/9] net: ip6_redirect_no_header() - use new style struct initializer instead of memset
2018-09-30 6:44 ` [PATCH v2 4/9] net: ip6_redirect_no_header() " Maciej Żenczykowski
@ 2018-10-01 15:22 ` David Ahern
0 siblings, 0 replies; 21+ messages in thread
From: David Ahern @ 2018-10-01 15:22 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller; +Cc: netdev
On 9/30/18 12:44 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> (allows for better compiler optimization)
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> net/ipv6/route.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 5/9] net: remove 1 always zero parameter from ip6_redirect_no_header()
2018-09-30 6:44 ` [PATCH v2 5/9] net: remove 1 always zero parameter from ip6_redirect_no_header() Maciej Żenczykowski
@ 2018-10-01 15:23 ` David Ahern
0 siblings, 0 replies; 21+ messages in thread
From: David Ahern @ 2018-10-01 15:23 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller; +Cc: netdev
On 9/30/18 12:44 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> (the parameter in question is mark)
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> include/net/ip6_route.h | 3 +--
> net/ipv6/ndisc.c | 2 +-
> net/ipv6/route.c | 4 +---
> 3 files changed, 3 insertions(+), 6 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 6/9] net: ip6_update_pmtu() - use new style struct initializer instead of memset
2018-09-30 6:44 ` [PATCH v2 6/9] net: ip6_update_pmtu() - use new style struct initializer instead of memset Maciej Żenczykowski
@ 2018-10-01 15:24 ` David Ahern
0 siblings, 0 replies; 21+ messages in thread
From: David Ahern @ 2018-10-01 15:24 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller; +Cc: netdev
On 9/30/18 12:44 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> (allows for better compiler optimization)
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> net/ipv6/route.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 2/9] net: inet_rtm_getroute() - use new style struct initializer instead of memset
2018-09-30 6:44 ` [PATCH v2 2/9] net: inet_rtm_getroute() " Maciej Żenczykowski
@ 2018-10-01 15:25 ` David Ahern
0 siblings, 0 replies; 21+ messages in thread
From: David Ahern @ 2018-10-01 15:25 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller; +Cc: netdev
On 9/30/18 12:44 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> net/ipv4/route.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 9/9] net: inet6_rtm_getroute() - use new style struct initializer instead of memset
2018-09-30 6:44 ` [PATCH v2 9/9] net: inet6_rtm_getroute() " Maciej Żenczykowski
@ 2018-10-01 15:26 ` David Ahern
0 siblings, 0 replies; 21+ messages in thread
From: David Ahern @ 2018-10-01 15:26 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller; +Cc: netdev
On 9/30/18 12:44 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> net/ipv6/route.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 8/9] net: rtm_to_fib6_config() - use new style struct initializer instead of memset
2018-09-30 6:44 ` [PATCH v2 8/9] net: rtm_to_fib6_config() " Maciej Żenczykowski
@ 2018-10-01 15:35 ` David Ahern
0 siblings, 0 replies; 21+ messages in thread
From: David Ahern @ 2018-10-01 15:35 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller; +Cc: netdev
On 9/30/18 12:44 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> (allows for better compiler optimization)
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> net/ipv6/route.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 7/9] net: rtmsg_to_fib6_config() - use new style struct initializer instead of memset
2018-09-30 6:44 ` [PATCH v2 7/9] net: rtmsg_to_fib6_config() " Maciej Żenczykowski
@ 2018-10-01 15:36 ` David Ahern
0 siblings, 0 replies; 21+ messages in thread
From: David Ahern @ 2018-10-01 15:36 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller; +Cc: netdev
On 9/30/18 12:44 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> (allows for better compiler optimization)
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> net/ipv6/route.c | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
` (8 preceding siblings ...)
2018-10-01 15:20 ` [PATCH v2 1/9] net: ip_rt_get_source() " David Ahern
@ 2018-10-02 23:13 ` David Miller
2018-10-02 23:25 ` Maciej Żenczykowski
9 siblings, 1 reply; 21+ messages in thread
From: David Miller @ 2018-10-02 23:13 UTC (permalink / raw)
To: zenczykowski; +Cc: maze, netdev, dsahern
All 9 patches applied, thanks.
Please provide a proper "0/N" header posting in furture patch series
submissions.
Thank you.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset
2018-10-02 23:13 ` David Miller
@ 2018-10-02 23:25 ` Maciej Żenczykowski
2018-10-03 0:01 ` David Miller
0 siblings, 1 reply; 21+ messages in thread
From: Maciej Żenczykowski @ 2018-10-02 23:25 UTC (permalink / raw)
To: David Miller; +Cc: Linux NetDev, dsahern
> Please provide a proper "0/N" header posting in furture patch series
> submissions.
>
> Thank you.
Seeing as all but 2 of these patches were entirely independent should
I have sent them as individual patches instead (with one patch pair)?
Or are series preferred even if I ended up reuploading 9 of 11 with no
changes after the NAK on the two in v1?
Thanks,
Maciej
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset
2018-10-02 23:25 ` Maciej Żenczykowski
@ 2018-10-03 0:01 ` David Miller
0 siblings, 0 replies; 21+ messages in thread
From: David Miller @ 2018-10-03 0:01 UTC (permalink / raw)
To: zenczykowski; +Cc: netdev, dsahern
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Tue, 2 Oct 2018 16:25:39 -0700
>> Please provide a proper "0/N" header posting in furture patch series
>> submissions.
>>
>> Thank you.
>
> Seeing as all but 2 of these patches were entirely independent should
> I have sent them as individual patches instead (with one patch pair)?
They are logically related, so a series is best in this case.
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2018-10-03 6:47 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-30 6:44 [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset Maciej Żenczykowski
2018-09-30 6:44 ` [PATCH v2 2/9] net: inet_rtm_getroute() " Maciej Żenczykowski
2018-10-01 15:25 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 3/9] net: ip6_redirect() " Maciej Żenczykowski
2018-10-01 15:22 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 4/9] net: ip6_redirect_no_header() " Maciej Żenczykowski
2018-10-01 15:22 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 5/9] net: remove 1 always zero parameter from ip6_redirect_no_header() Maciej Żenczykowski
2018-10-01 15:23 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 6/9] net: ip6_update_pmtu() - use new style struct initializer instead of memset Maciej Żenczykowski
2018-10-01 15:24 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 7/9] net: rtmsg_to_fib6_config() " Maciej Żenczykowski
2018-10-01 15:36 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 8/9] net: rtm_to_fib6_config() " Maciej Żenczykowski
2018-10-01 15:35 ` David Ahern
2018-09-30 6:44 ` [PATCH v2 9/9] net: inet6_rtm_getroute() " Maciej Żenczykowski
2018-10-01 15:26 ` David Ahern
2018-10-01 15:20 ` [PATCH v2 1/9] net: ip_rt_get_source() " David Ahern
2018-10-02 23:13 ` David Miller
2018-10-02 23:25 ` Maciej Żenczykowski
2018-10-03 0:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).