From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomas Bortoli <tomasbortoli@gmail.com>
Subject: Re: [PATCH 1/3] 9p/net: implement asynchronous rpc
Date: Mon, 17 Dec 2018 23:14:53 +0100
Message-ID: <1bcb0d99-fc35-3390-e751-5c4ad623e418@gmail.com>
References: <1544532108-21689-1-git-send-email-asmadeus@codewreck.org>
 <0da7d896-0d67-46f6-83f9-b346eba991a9@gmail.com>
 <20181217110111.GB17466@nautica>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: v9fs-developer@lists.sourceforge.net,
        Dominique Martinet <dominique.martinet@cea.fr>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Dmitry Vyukov <dvyukov@google.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20181217110111.GB17466@nautica>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On 12/17/18 12:01 PM, Dominique Martinet wrote:
> Tomas Bortoli wrote on Mon, Dec 17, 2018:
>> sorry for the delay, I've been quite busy these days.
> 
> No problem.
> 
>> The patches looks good to me and should indeed speed up the code a bit.
>> I quickly tested them against Syzkaller tuned for the 9p subsystem and
>> everything seems fine.
> 
> Thanks, can I add your Reviewed-by on all three?
> 

Sure, FWIW.

>> And by the way, which refcount races?
> 
> There's a problem with trans_fd read_work and cancelled callback; I'm
> not so sure about refcount but we can definitely get double list_del
> as we're not checking the status. I think when we incorrectly remove
> from the list we also mismanage the refcount, but honestly need to
> test..
> 

Yeah, definitely it needs  to check the status. Btw, if a double
list_del happens the kernel should crash.