From: Julia Lawall <julia.lawall@inria.fr>
To: Jakub Kicinski <kuba@kernel.org>
Cc: MD Danish Anwar <danishanwar@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Fan Gong <gongfan1@huawei.com>, Lee Trager <lee@trager.us>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lukas Bulwahn <lukas.bulwahn@redhat.com>,
Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, cocci@inria.fr,
Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver
Date: Mon, 4 Aug 2025 14:10:15 +0200 (CEST) [thread overview]
Message-ID: <1bf7c9-d394-7519-795b-c8d455ee9d0@inria.fr> (raw)
In-Reply-To: <20250723064901.0b7ec997@kernel.org>
On Wed, 23 Jul 2025, Jakub Kicinski wrote:
> On Wed, 23 Jul 2025 13:33:18 +0530 MD Danish Anwar wrote:
> > + - Vendors must ensure the magic number matches the value expected by the
> > + Linux driver (see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
> > + source).
>
> For some reason this trips up make coccicheck:
>
> EXN: Failure("unexpected paren order") in /home/cocci/testing/Documentation/networking/device_drivers/ethernet/rpmsg_eth.rst
>
> If I replace the brackets with a comma it works:
>
> - Vendors must ensure the magic number matches the value expected by the
> Linux driver, see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
> source.
>
> Could you make that change in the next revision to avoid the problem?
>
> Julia, is there an easy way to make coccinelle ignore files which
> don't end with .c or .h when using --use-patch-diff ?
Perhaps not. I can adjust it.
julia
next prev parent reply other threads:[~2025-08-04 12:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 8:03 [PATCH net-next 0/5] Add RPMSG Ethernet Driver MD Danish Anwar
2025-07-23 8:03 ` [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver MD Danish Anwar
2025-07-23 13:49 ` Jakub Kicinski
2025-07-24 6:54 ` MD Danish Anwar
2025-08-04 12:10 ` Julia Lawall [this message]
2025-07-23 16:24 ` Andrew Lunn
2025-07-24 8:24 ` MD Danish Anwar
2025-07-24 16:37 ` Andrew Lunn
2025-07-25 7:04 ` Anwar, Md Danish
2025-08-28 7:08 ` MD Danish Anwar
2025-08-29 0:39 ` Bagas Sanjaya
2025-07-23 8:03 ` [PATCH net-next 2/5] net: rpmsg-eth: Add basic rpmsg skeleton MD Danish Anwar
2025-07-24 19:18 ` Krzysztof Kozlowski
2025-07-28 8:10 ` MD Danish Anwar
2025-07-28 12:40 ` Krzysztof Kozlowski
2025-07-29 9:46 ` MD Danish Anwar
2025-07-29 12:32 ` Krzysztof Kozlowski
2025-07-30 6:01 ` MD Danish Anwar
2025-07-30 6:13 ` Krzysztof Kozlowski
2025-07-30 15:11 ` Anwar, Md Danish
2025-08-28 7:07 ` MD Danish Anwar
2025-07-23 8:03 ` [PATCH net-next 3/5] net: rpmsg-eth: Register device as netdev MD Danish Anwar
2025-07-23 8:03 ` [PATCH net-next 4/5] net: rpmsg-eth: Add netdev ops MD Danish Anwar
2025-07-23 8:03 ` [PATCH net-next 5/5] net: rpmsg-eth: Add support for multicast filtering MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bf7c9-d394-7519-795b-c8d455ee9d0@inria.fr \
--to=julia.lawall@inria.fr \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=cocci@inria.fr \
--cc=corbet@lwn.net \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=gongfan1@huawei.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=maddy@linux.ibm.com \
--cc=mengyuanlou@net-swift.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).