From: "Fuxbrumer, Dvora" <dvorax.fuxbrumer@linux.intel.com>
To: trix@redhat.com, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org,
jeffrey.t.kirsher@intel.com, sasha.neftin@intel.com
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] igc: change default return of igc_read_phy_reg()
Date: Thu, 24 Jun 2021 22:58:28 +0300 [thread overview]
Message-ID: <1c0592d7-7d54-7834-61d4-f6b3183b5cf2@linux.intel.com> (raw)
In-Reply-To: <20210521195019.2078661-1-trix@redhat.com>
On 5/21/2021 22:50, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Static analysis reports this problem
>
> igc_main.c:4944:20: warning: The left operand of '&'
> is a garbage value
> if (!(phy_data & SR_1000T_REMOTE_RX_STATUS) &&
> ~~~~~~~~ ^
>
> pyy_data is set by the call to igc_read_phy_reg() only if
> there is a read_reg() op, else it is unset and a 0 is
> returned. Change the return to -EOPNOTSUPP.
>
> Fixes: 208983f099d9 ("igc: Add watchdog")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/net/ethernet/intel/igc/igc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
prev parent reply other threads:[~2021-06-24 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 19:50 [PATCH] igc: change default return of igc_read_phy_reg() trix
2021-05-23 5:47 ` Neftin, Sasha
2021-06-24 19:58 ` Fuxbrumer, Dvora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c0592d7-7d54-7834-61d4-f6b3183b5cf2@linux.intel.com \
--to=dvorax.fuxbrumer@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).