From: Andrew Lunn <andrew@lunn.ch>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: set struct net_device::name earlier
Date: Sun, 19 May 2024 00:04:05 +0200 [thread overview]
Message-ID: <1c1dd2da-9541-4d9c-a302-0a961862cedd@lunn.ch> (raw)
In-Reply-To: <d116cbdb-4dc5-484a-b53b-fec50f8ef2bf@p183>
On Sat, May 18, 2024 at 11:24:57PM +0300, Alexey Dobriyan wrote:
> I've tried debugging networking allocations with bpftrace and doing
>
> $dev = (struct net_device*)arg0;
> printf("dev %s\n", $dev->name);
>
> doesn't print anything useful in functions called right after netdevice
> allocation. The reason is very simple: dev->name has not been set yet.
>
> Make name copying much earlier for smoother debugging experience.
Does this really help? Instead of "" don't you get "eth%d"? The
expansion of the %d to eth42 does not happen until you register the
netdev.
Andrew
next prev parent reply other threads:[~2024-05-18 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 20:24 [PATCH] net: set struct net_device::name earlier Alexey Dobriyan
2024-05-18 22:04 ` Andrew Lunn [this message]
2024-05-19 5:41 ` Alexey Dobriyan
2024-05-19 13:42 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c1dd2da-9541-4d9c-a302-0a961862cedd@lunn.ch \
--to=andrew@lunn.ch \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox