From: Sean Anderson <sean.anderson@linux.dev>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] net: fman_memac: Don't use of_property_read_bool on non-boolean property managed
Date: Tue, 10 Jun 2025 11:32:35 -0400 [thread overview]
Message-ID: <1c4ce7df-dd5e-43a7-a496-bf5b89086e25@linux.dev> (raw)
In-Reply-To: <20250610114057.414791-1-alexander.stein@ew.tq-group.com>
On 6/10/25 07:40, Alexander Stein wrote:
> 'managed' is a non-boolean property specified in ethernet-controller.yaml.
> Since commit c141ecc3cecd7 ("of: Warn when of_property_read_bool() is
> used on non-boolean properties") this raises a warning. Use the
> replacement of_property_present() instead.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/net/ethernet/freescale/fman/fman_memac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
> index 3925441143fac..0291093f2e4e4 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_memac.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
> @@ -1225,7 +1225,7 @@ int memac_initialization(struct mac_device *mac_dev,
> * be careful and not enable this if we are using MII or RGMII, since
> * those configurations modes don't use in-band autonegotiation.
> */
> - if (!of_property_read_bool(mac_node, "managed") &&
> + if (!of_property_present(mac_node, "managed") &&
> mac_dev->phy_if != PHY_INTERFACE_MODE_MII &&
> !phy_interface_mode_is_rgmii(mac_dev->phy_if))
> mac_dev->phylink_config.default_an_inband = true;
Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
next prev parent reply other threads:[~2025-06-10 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 11:40 [PATCH 1/1] net: fman_memac: Don't use of_property_read_bool on non-boolean property managed Alexander Stein
2025-06-10 15:32 ` Sean Anderson [this message]
2025-06-11 21:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c4ce7df-dd5e-43a7-a496-bf5b89086e25@linux.dev \
--to=sean.anderson@linux.dev \
--cc=alexander.stein@ew.tq-group.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).