From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2-next v2 2/2] gre/gre6: allow clearing {,i,o}{key,seq,csum} flags Date: Mon, 23 Apr 2018 20:48:15 -0600 Message-ID: <1c57166e-413d-9273-3af1-5b7387de06ae@gmail.com> References: <0906394e032f7a11b92c11bf74d0a7b31ffd9c30.1524173201.git.sd@queasysnail.net> <7cdd18dd490289b7d337c77ec296de1b93b5a126.1524173201.git.sd@queasysnail.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Sabrina Dubroca , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f53.google.com ([74.125.83.53]:36661 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932726AbeDXCsW (ORCPT ); Mon, 23 Apr 2018 22:48:22 -0400 Received: by mail-pg0-f53.google.com with SMTP id i6so9743671pgv.3 for ; Mon, 23 Apr 2018 19:48:22 -0700 (PDT) In-Reply-To: <7cdd18dd490289b7d337c77ec296de1b93b5a126.1524173201.git.sd@queasysnail.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/20/18 2:32 AM, Sabrina Dubroca wrote: > Currently, iproute allows setting those flags, but it's impossible to > clear them, since their current value is fetched from the kernel and > then we OR in the additional flags passed on the command line. > > Add no* variants to allow clearing them. > > Signed-off-by: Sabrina Dubroca > --- > v2: fixed up okey flag clearing > also reset the actual value of the key, not just the flag both applied to iproute2-next. Thanks,