From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile Date: Tue, 15 Aug 2017 10:50:46 -0700 Message-ID: <1c9c2754-d45e-fdf8-0507-6295b69d66e4@infradead.org> References: <20170815130806.25168-1-mohamed.a.alrshah@ieee.org> <5fac1100-c7d3-85ed-8230-53e6ffb3df0a@infradead.org> <20170815.103651.1877616739706523154.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: ncardwell@google.com, mohamed.a.alrshah@ieee.org, netdev@vger.kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mothman@upm.edu.my, borhan@upm.edu.my, zurinamh@upm.edu.my To: David Miller Return-path: In-Reply-To: <20170815.103651.1877616739706523154.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 08/15/2017 10:36 AM, David Miller wrote: > From: Randy Dunlap > Date: Tue, 15 Aug 2017 09:41:53 -0700 > >> On 08/15/2017 06:51 AM, Neal Cardwell wrote: >>> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah >>> wrote: >>> >>>> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight) >>>> +{ >>>> + struct tcp_sock *tp = tcp_sk(sk); >>>> + struct agilesdtcp *ca = inet_csk_ca(sk); >>>> + u32 inc_factor; >>>> + u32 ca_inc; >>>> + u32 current_gap, total_gap; >>> >>> For coding style, please order local variable declarations from >>> longest to shortest line, also know as Reverse Christmas Tree Format. >> >> Per what coding style, please? This is not in current coding style nor in the >> netdev-FAQ exceptions. > > It is the established practice, documented or not, and I enforce this for all > networking code submissions. I see. Thanks for clarifying that. -- ~Randy