Netdev List
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: network dev <netdev@vger.kernel.org>
Subject: Re: [PATCH v15 net-next 1/2] octeontx2: use atomic bitops for PF/VF and rep flags
Date: Thu, 17 Sep 2026 13:36:54 +0200	[thread overview]
Message-ID: <1ca84bcb-016a-4dce-b80f-66b9fcdb9173@redhat.com> (raw)
In-Reply-To: <aqdmy0GU7pV6wryi@rkannoth-OptiPlex-7090>

On 9/14/26 05:15, Ratheesh Kannoth wrote:
> On 2026-09-12 at 16:26:28, sashiko-bot@kernel.org (sashiko-bot@kernel.org) wrote:
>> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
>>
>> Pre-existing issues:
>> - [High] TC offload setup on representors corrupts the shared physical function (PF) device state by locklessly overwriting its netdev and clobbering its flags via a non-atomic bitwise sync loop.
>> - [High] Inverted logic in `otx2_tc_del_flow()` prematurely disables TC MARK hardware offload when any single mark rule is deleted.
>> - [High] Missing cancellation of `stats_wrk` leads to a Use-After-Free during representor teardown.
>> - [High] `rvu_rep_mcam_flow_init()` interacts with the mailbox without acquiring its lock and executes an unbalanced `mutex_unlock()`.
>> --
> 
> I will address these in separate follow-up patches to the 'net' tree once this series is merged.

Note that the relevant sashiko instance for netdev is:

https://netdev-ai.bots.linux.dev/sashiko/

Findings from such instance include the public ones, cross validates 
with additional LLM models. You can look exclusively to the nipa one.

/P


  parent reply	other threads:[~2026-09-17 11:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 10:55 [PATCH v15 net-next 0/2] octeontx2-pf: mqprio bandwidth offload for NIX TX schedulers Ratheesh Kannoth
2026-09-11 10:55 ` [PATCH v15 net-next 1/2] octeontx2: use atomic bitops for PF/VF and rep flags Ratheesh Kannoth
2026-09-17 11:31   ` Paolo Abeni
     [not found]   ` <20260912105628.B3E251F000FF@smtp.kernel.org>
     [not found]     ` <aqdmy0GU7pV6wryi@rkannoth-OptiPlex-7090>
2026-09-17 11:36       ` Paolo Abeni [this message]
2026-09-11 10:55 ` [PATCH v15 net-next 2/2] octeontx2-pf: add mqprio bandwidth offload for NIX TX schedulers Ratheesh Kannoth
2026-09-17 11:31   ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ca84bcb-016a-4dce-b80f-66b9fcdb9173@redhat.com \
    --to=pabeni@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rkannoth@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox