From: Andrew Lunn <andrew@lunn.ch>
To: Ashwin Gundarapu <linuxuser509@zohomail.in>
Cc: netdev <netdev@vger.kernel.org>,
linux-usb <linux-usb@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: usb: net1080: add error handling to nc_vendor_write()
Date: Tue, 28 Jul 2026 23:05:58 +0200 [thread overview]
Message-ID: <1caa928e-fb7a-464b-a9af-1135569fd6da@lunn.ch> (raw)
In-Reply-To: <19fa888e049.512e8c5e24030.7986824281565553606@zohomail.in>
On Tue, Jul 28, 2026 at 05:12:50PM +0530, Ashwin Gundarapu wrote:
> >From 8c6ffd0b1a5ac33fb6a81cfd4d7d2c54462233bc Mon Sep 17 00:00:00 2001
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Mon, 27 Jul 2026 19:34:16 +0530
> Subject: [PATCH] net: usb: net1080: add error handling to nc_vendor_write()
>
> The nc_vendor_write() function currently ignores the return value of
> usbnet_write_cmd(). This can lead to silent failures when USB
> communication fails.
>
> Change nc_vendor_write() and nc_register_write() to return int
> instead of void, and propagate the error from usbnet_write_cmd()
> back to the caller.
>
> Also fix the callers in net1080_reset() to check the return value
> and handle errors appropriately. Remove an unused #if 0 block while
> at it.
This patch is doing multiple things. Please turn it into two patches
in a series.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-07-28 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 11:42 [PATCH v2] net: usb: net1080: add error handling to nc_vendor_write() Ashwin Gundarapu
2026-07-28 21:05 ` Andrew Lunn [this message]
2026-07-31 13:25 ` kernel test robot
2026-07-31 13:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1caa928e-fb7a-464b-a9af-1135569fd6da@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxuser509@zohomail.in \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox