From: David Ahern <dsahern@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net 2/3] net/ipv6: remove the old peer route if change it to a new one
Date: Tue, 3 Mar 2020 08:58:21 -0700 [thread overview]
Message-ID: <1cb697e7-eefa-360d-9431-10ad95f2fd42@gmail.com> (raw)
In-Reply-To: <20200303063736.4904-3-liuhangbin@gmail.com>
On 3/2/20 11:37 PM, Hangbin Liu wrote:
> When we modify the peer route and changed it to a new one, we should
> remove the old route first. Before the fix:
>
> + ip addr add dev dummy1 2001:db8::1 peer 2001:db8::2
> + ip -6 route show dev dummy1
> 2001:db8::1 proto kernel metric 256 pref medium
> 2001:db8::2 proto kernel metric 256 pref medium
> + ip addr change dev dummy1 2001:db8::1 peer 2001:db8::3
> + ip -6 route show dev dummy1
> 2001:db8::1 proto kernel metric 256 pref medium
> 2001:db8::2 proto kernel metric 256 pref medium
>
> After the fix:
> + ip addr change dev dummy1 2001:db8::1 peer 2001:db8::3
> + ip -6 route show dev dummy1
> 2001:db8::1 proto kernel metric 256 pref medium
> 2001:db8::3 proto kernel metric 256 pref medium
>
> This patch depend on the previous patch "net/ipv6: need update peer route
> when modify metric" to update new peer route after delete old one.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> net/ipv6/addrconf.c | 21 +++++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2020-03-03 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 6:37 [PATCH net 0/3] Fix IPv6 peer route update Hangbin Liu
2020-03-03 6:37 ` [PATCH net 1/3] net/ipv6: need update peer route when modify metric Hangbin Liu
2020-03-03 15:58 ` David Ahern
2020-03-03 6:37 ` [PATCH net 2/3] net/ipv6: remove the old peer route if change it to a new one Hangbin Liu
2020-03-03 15:58 ` David Ahern [this message]
2020-03-03 6:37 ` [PATCH net 3/3] selftests/net/fib_tests: update addr_metric_test for peer route testing Hangbin Liu
2020-03-03 15:58 ` David Ahern
2020-03-03 22:46 ` [PATCH net 0/3] Fix IPv6 peer route update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cb697e7-eefa-360d-9431-10ad95f2fd42@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).