From mboxrd@z Thu Jan 1 00:00:00 1970 From: YueHaibing Subject: Re: [PATCH] cxgb4: remove set but not used variable 'spd' Date: Mon, 13 Aug 2018 14:50:44 +0800 Message-ID: <1cd1bf32-e4a6-c0ae-c5c0-f991968b4ba0@huawei.com> References: <20180813064851.912-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: , To: , Return-path: In-Reply-To: <20180813064851.912-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Sorry, this should be for net-next On 2018/8/13 14:48, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'print_port_info': > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5147:14: warning: > variable 'spd' set but not used [-Wunused-but-set-variable] > > variable 'spd' is set but not used since > commit 547fd27241a8 ("cxgb4: Warn if device doesn't have enough PCI bandwidth") > > Signed-off-by: YueHaibing > --- > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > index 69590cf..961e3087 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > @@ -5144,17 +5144,9 @@ static void print_port_info(const struct net_device *dev) > { > char buf[80]; > char *bufp = buf; > - const char *spd = ""; > const struct port_info *pi = netdev_priv(dev); > const struct adapter *adap = pi->adapter; > > - if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_2_5GB) > - spd = " 2.5 GT/s"; > - else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_5_0GB) > - spd = " 5 GT/s"; > - else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_8_0GB) > - spd = " 8 GT/s"; > - > if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_100M) > bufp += sprintf(bufp, "100M/"); > if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_1G) >