netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Xin Long <lucien.xin@gmail.com>,
	network dev <netdev@vger.kernel.org>,
	stephen@networkplumber.org
Cc: David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCHv4 iproute2-next 2/7] iproute_lwtunnel: add options support for vxlan metadata
Date: Wed, 29 Apr 2020 10:58:36 -0600	[thread overview]
Message-ID: <1cd96ed3-b2ec-6cc7-8737-0cc2ecd38f72@gmail.com> (raw)
In-Reply-To: <838c55576eabd17db407a95bc6609c05bf5e174b.1587983178.git.lucien.xin@gmail.com>

On 4/27/20 4:27 AM, Xin Long wrote:
> diff --git a/ip/iproute_lwtunnel.c b/ip/iproute_lwtunnel.c
> index 8599853..9945c86 100644
> --- a/ip/iproute_lwtunnel.c
> +++ b/ip/iproute_lwtunnel.c
> @@ -333,6 +333,26 @@ static void lwtunnel_print_geneve_opts(struct rtattr *attr)
>  	close_json_array(PRINT_JSON, name);
>  }
>  
> +static void lwtunnel_print_vxlan_opts(struct rtattr *attr)
> +{
> +	struct rtattr *tb[LWTUNNEL_IP_OPT_VXLAN_MAX + 1];
> +	struct rtattr *i = RTA_DATA(attr);
> +	int rem = RTA_PAYLOAD(attr);
> +	char *name = "vxlan_opts";
> +	__u32 gbp;
> +
> +	parse_rtattr(tb, LWTUNNEL_IP_OPT_VXLAN_MAX, i, rem);
> +	gbp = rta_getattr_u32(tb[LWTUNNEL_IP_OPT_VXLAN_GBP]);
> +
> +	print_nl();
> +	print_string(PRINT_FP, name, "\t%s ", name);
> +	open_json_array(PRINT_JSON, name);
> +	open_json_object(NULL);
> +	print_uint(PRINT_ANY, "gdp", "%u ", gbp);

gdp? should that be 'gbp'?


  reply	other threads:[~2020-04-29 16:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 10:27 [PATCHv4 iproute2-next 0/7] iproute2: fully support for geneve/vxlan/erspan options Xin Long
2020-04-27 10:27 ` [PATCHv4 iproute2-next 1/7] iproute_lwtunnel: add options support for geneve metadata Xin Long
2020-04-27 10:27 ` [PATCHv4 iproute2-next 2/7] iproute_lwtunnel: add options support for vxlan metadata Xin Long
2020-04-29 16:58   ` David Ahern [this message]
2020-04-30  5:12     ` Xin Long
2020-04-30 16:19       ` David Ahern
2020-04-30 18:09         ` Xin Long
2020-04-27 10:27 ` [PATCHv4 iproute2-next 3/7] iproute_lwtunnel: add options support for erspan metadata Xin Long
2020-04-27 10:27 ` [PATCHv4 iproute2-next 4/7] tc: m_tunnel_key: add options support for vxlan Xin Long
2020-04-27 10:27 ` [PATCHv4 iproute2-next 5/7] tc: m_tunnel_key: add options support for erpsan Xin Long
2020-04-27 10:27 ` [PATCHv4 iproute2-next 6/7] tc: f_flower: add options support for vxlan Xin Long
2020-04-27 10:27 ` [PATCHv4 iproute2-next 7/7] tc: f_flower: add options support for erspan Xin Long
2020-05-01 16:33 ` [PATCHv4 iproute2-next 0/7] iproute2: fully support for geneve/vxlan/erspan options David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cd96ed3-b2ec-6cc7-8737-0cc2ecd38f72@gmail.com \
    --to=dsahern@gmail.com \
    --cc=kuba@kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).