From: Justin Lai <justinlai0215@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"andrew@lunn.ch" <andrew@lunn.ch>
Subject: RE: [PATCH net-next v6 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code
Date: Wed, 23 Aug 2023 14:20:47 +0000 [thread overview]
Message-ID: <1cdd197b38804b4d95cf82a21d73aab1@realtek.com> (raw)
In-Reply-To: <20230822103750.6dbb6fc2@kernel.org>
> On Tue, 22 Aug 2023 11:18:04 +0800 Justin Lai wrote:
> > drivers/net/ethernet/realtek/rtase/rtase.h | 372 +++
> > .../net/ethernet/realtek/rtase/rtase_main.c | 2432 +++++++++++++++++
> > 5 files changed, 2832 insertions(+)
>
> Please split this into multiple patches, I already asked you to do so.
>
> Individual ethtool ops and vlan support should be separate patches, perhaps
> you can separate other features out, too.
>
Thanks for your review, I will make this change in the next version.
next prev parent reply other threads:[~2023-08-23 14:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 3:18 [PATCH net-next v6 0/2] Add Realtek automotive PCIe driver Justin Lai
2023-08-22 3:18 ` [PATCH net-next v6 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code Justin Lai
2023-08-22 17:37 ` Jakub Kicinski
2023-08-23 14:20 ` Justin Lai [this message]
2023-08-22 17:51 ` Andrew Lunn
2023-08-23 14:25 ` Justin Lai
2023-08-22 17:59 ` Andrew Lunn
2023-08-23 14:28 ` Justin Lai
2023-08-22 3:18 ` [PATCH net-next v6 2/2] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cdd197b38804b4d95cf82a21d73aab1@realtek.com \
--to=justinlai0215@realtek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).