From: Andrew Lunn <andrew@lunn.ch>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 net-next] net: fec_mpc52xx: remove dead resource size check
Date: Thu, 17 Sep 2026 16:56:32 +0200 [thread overview]
Message-ID: <1ce3192c-d052-4936-9567-8a1d9b13f54a@lunn.ch> (raw)
In-Reply-To: <20260916223228.271815-1-rosenp@gmail.com>
On Wed, Sep 16, 2026 at 03:32:28PM -0700, Rosen Penev wrote:
> The check bails out if the FEC register resource is smaller than
> sizeof(struct mpc52xx_fec), but every in-tree device tree describes
> the FEC node as a 0x400 byte region, which is exactly the size of the
> struct, so the condition can never be true.
We generally don't fully trust DT blobs.
Does this test do any actual harm in its current state?
Why remove it?
Andrew
next prev parent reply other threads:[~2026-09-17 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 22:32 [PATCHv2 net-next] net: fec_mpc52xx: remove dead resource size check Rosen Penev
2026-09-17 14:56 ` Andrew Lunn [this message]
2026-09-17 18:30 ` Rosen Penev
2026-09-20 22:47 ` netdev-bot+sashiko
2026-09-21 1:19 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ce3192c-d052-4936-9567-8a1d9b13f54a@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox