From: Michal Simek <michal.simek@xilinx.com>
To: linux-kernel@vger.kernel.org
Cc: Michal Simek <monstr@monstr.eu>,
Michal Simek <michal.simek@xilinx.com>,
"David S. Miller" <davem@davemloft.net>,
Lars-Peter Clausen <lars@metafoo.de>,
Christian Hohnstaedt <chohnstaedt@innominate.com>,
Rick Hoover <RHoover@digilentinc.com>,
netdev@vger.kernel.org
Subject: [PATCH 03/11] phy: Use macros instead of hardcoded values in marvell phy driver
Date: Wed, 29 May 2013 17:33:03 +0200 [thread overview]
Message-ID: <1ce55f2ae709b48733bb68e05253c23a4e90f1ae.1369841519.git.michal.simek@xilinx.com> (raw)
In-Reply-To: <131c9262c3094ee3c664bd729a66e0709ceae82c.1369841519.git.michal.simek@xilinx.com>
In-Reply-To: <131c9262c3094ee3c664bd729a66e0709ceae82c.1369841519.git.michal.simek@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
Use macros from linux/marvell_phy.h instead of duplicate
magic phy ID in the driver.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/net/phy/marvell.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 202fe1f..371353c 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -958,15 +958,15 @@ module_init(marvell_init);
module_exit(marvell_exit);
static struct mdio_device_id __maybe_unused marvell_tbl[] = {
- { 0x01410c60, 0xfffffff0 },
- { 0x01410c90, 0xfffffff0 },
- { 0x01410cc0, 0xfffffff0 },
- { 0x01410e10, 0xfffffff0 },
- { 0x01410cb0, 0xfffffff0 },
- { 0x01410cd0, 0xfffffff0 },
- { 0x01410e50, 0xfffffff0 },
- { 0x01410e30, 0xfffffff0 },
- { 0x01410e90, 0xfffffff0 },
+ { MARVELL_PHY_ID_88E1101, MARVELL_PHY_ID_MASK },
+ { MARVELL_PHY_ID_88E1112, MARVELL_PHY_ID_MASK },
+ { MARVELL_PHY_ID_88E1111, MARVELL_PHY_ID_MASK },
+ { MARVELL_PHY_ID_88E1118, MARVELL_PHY_ID_MASK },
+ { MARVELL_PHY_ID_88E1121R, MARVELL_PHY_ID_MASK },
+ { MARVELL_PHY_ID_88E1145, MARVELL_PHY_ID_MASK },
+ { MARVELL_PHY_ID_88E1149R, MARVELL_PHY_ID_MASK },
+ { MARVELL_PHY_ID_88E1240, MARVELL_PHY_ID_MASK },
+ { MARVELL_PHY_ID_88E1318S, MARVELL_PHY_ID_MASK },
{ }
};
--
1.8.2.3
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-05-29 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 15:33 [PATCH 01/11] phy: Clean coding style in vitesse phy Michal Simek
2013-05-29 15:33 ` [PATCH 02/11] phy: Add Vitesse 8211 phy ID Michal Simek
2013-05-29 15:33 ` Michal Simek [this message]
2013-05-29 15:33 ` [PATCH 04/11] phy: Add Marvell 88E1116R " Michal Simek
2013-05-29 15:33 ` [PATCH 05/11] phy: Add Marvell 88E1510 " Michal Simek
2013-05-29 15:33 ` [PATCH 06/11] net: emaclite: Report failures in mdio setup Michal Simek
2013-05-29 15:33 ` [PATCH 07/11] net: emaclite: Support multiple phys connected to one MDIO bus Michal Simek
2013-05-29 15:33 ` [PATCH 08/11] net: emaclite: Let's make xemaclite_adjust_link static Michal Simek
2013-05-29 15:33 ` [PATCH 09/11] net: emaclite: Do not use microblaze and ppc IO functions Michal Simek
2013-05-29 16:04 ` Michal Simek
2013-05-29 15:33 ` [PATCH 10/11] net: emaclite: Enable emaclite for Xilinx Arm Zynq platform Michal Simek
2013-05-29 15:33 ` [PATCH 11/11] net: emaclite: Update driver header Michal Simek
2013-05-29 17:11 ` Sergei Shtylyov
2013-05-30 5:14 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ce55f2ae709b48733bb68e05253c23a4e90f1ae.1369841519.git.michal.simek@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=RHoover@digilentinc.com \
--cc=chohnstaedt@innominate.com \
--cc=davem@davemloft.net \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).