From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71517C76191 for ; Thu, 25 Jul 2019 01:40:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55C5D21926 for ; Thu, 25 Jul 2019 01:40:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387905AbfGYBkl (ORCPT ); Wed, 24 Jul 2019 21:40:41 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:35876 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726808AbfGYBkl (ORCPT ); Wed, 24 Jul 2019 21:40:41 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8A9CB1451149D3AC8C95; Thu, 25 Jul 2019 09:40:38 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Thu, 25 Jul 2019 09:40:30 +0800 Subject: Re: [PATCH] carl9170: remove set but not used variable 'udev' To: Christian Lamparter References: <20190724015411.66525-1-yuehaibing@huawei.com> CC: Kalle Valo , linux-wireless , Netdev , , linux-kernel , Hulk Robot From: Yuehaibing Message-ID: <1cfbfe67-e931-029b-1836-a6b796283c2c@huawei.com> Date: Thu, 25 Jul 2019 09:40:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/7/25 3:42, Christian Lamparter wrote: > On Wed, Jul 24, 2019 at 3:48 AM YueHaibing wrote: >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/wireless/ath/carl9170/usb.c: In function 'carl9170_usb_disconnect': >> drivers/net/wireless/ath/carl9170/usb.c:1110:21: warning: >> variable 'udev' set but not used [-Wunused-but-set-variable] >> >> It is not used, so can be removed. >> >> Reported-by: Hulk Robot >> Signed-off-by: YueHaibing >> --- > Isn't this the same patch you sent earlier: > > https://patchwork.kernel.org/patch/11027909/ > >>>From what I can tell, it's the same but with an extra [-next], I > remember that I've acked that one > but your patch now does not have it? Is this an oversight, because I'm > the maintainer for this > driver. So, in my opinion at least the "ack" should have some value > and shouldn't be "ignored". > > Look, from what I know, Kalle is not ignoring you, It's just that > carl9170 is no longer top priority. > So please be patient. As long as its queued in the patchwork it will > get considered. Thank you for reminder. I forget the previous patch，and our CI robot report it again, So I do it again, sorry for confusion. Just pls drop this and use previous one. > > Cheers, > Christian > >> drivers/net/wireless/ath/carl9170/usb.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/carl9170/usb.c b/drivers/net/wireless/ath/carl9170/usb.c >> index 99f1897a775d..486957a04bd1 100644 >> --- a/drivers/net/wireless/ath/carl9170/usb.c >> +++ b/drivers/net/wireless/ath/carl9170/usb.c >> @@ -1107,12 +1107,10 @@ static int carl9170_usb_probe(struct usb_interface *intf, >> static void carl9170_usb_disconnect(struct usb_interface *intf) >> { >> struct ar9170 *ar = usb_get_intfdata(intf); >> - struct usb_device *udev; >> >> if (WARN_ON(!ar)) >> return; >> >> - udev = ar->udev; >> wait_for_completion(&ar->fw_load_wait); >> >> if (IS_INITIALIZED(ar)) { >> >> >> > > . >