Re: [PATCH net-next 01/10] ipv4: Replace route in list before notifying

[David Ahern <dsahern@gmail.com>]

On 1/7/20 8:45 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@mellanox.com>
> 
> Subsequent patches will add an offload / trap indication to routes which
> will signal if the route is present in hardware or not.
> 
> After programming the route to the hardware, drivers will have to ask
> the IPv4 code to set the flags by passing the route's key.
> 
> In the case of route replace, the new route is notified before it is
> actually inserted into the FIB alias list. This can prevent simple
> drivers (e.g., netdevsim) that program the route to the hardware in the
> same context it is notified in from being able to set the flag.
> 
> Solve this by first inserting the new route to the list and rollback the
> operation in case the route was vetoed.
> 
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
> ---
>  net/ipv4/fib_trie.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@gmail.com>