From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E6B2C64E90 for ; Mon, 30 Nov 2020 23:46:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A4C8207BB for ; Mon, 30 Nov 2020 23:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730623AbgK3Xpz (ORCPT ); Mon, 30 Nov 2020 18:45:55 -0500 Received: from mga05.intel.com ([192.55.52.43]:51667 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728509AbgK3Xpy (ORCPT ); Mon, 30 Nov 2020 18:45:54 -0500 IronPort-SDR: uIDDEzgIo1BDpUhAI6BsC8LJzdYGV1B/m7FecsHU4jJLF0+I44LjuqSqJdkY8kwCF07Tc6lvXY JO/ct30XabPA== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="257441107" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="257441107" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 15:44:14 -0800 IronPort-SDR: Q4yrFjSk58UJJTwmQ5A2aSWX+/0eLKJWmHtSiUCDgvOo2a4MyMWQ5gsZTx8u+hiNge+kNO2jV8 nywh+DAD4tPQ== X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="480855685" Received: from cdhirema-mobl5.amr.corp.intel.com ([10.254.71.173]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 15:44:14 -0800 Date: Mon, 30 Nov 2020 15:44:13 -0800 (PST) From: Mat Martineau To: Paolo Abeni cc: netdev@vger.kernel.org, Jakub Kicinski , mptcp@lists.01.org, Eric Dumazet Subject: Re: [PATCH net-next 4/6] mptcp: allocate TX skbs in msk context In-Reply-To: <2c4eacb182281d8e65cf4cf521e05141e6b011c8.1606413118.git.pabeni@redhat.com> Message-ID: <1d213fb6-34a4-668e-e972-47e11f7061b@linux.intel.com> References: <2c4eacb182281d8e65cf4cf521e05141e6b011c8.1606413118.git.pabeni@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 27 Nov 2020, Paolo Abeni wrote: > Move the TX skbs allocation in mptcp_sendmsg() scope, > and tentatively pre-allocate a skbs number proportional > to the sendmsg() length. > > Use the ssk tx skb cache to prevent the subflow allocation. > > This allows removing the msk skb extension cache and will > make possible the later patches. > > Acked-by: Florian Westphal > Signed-off-by: Paolo Abeni > --- > net/mptcp/protocol.c | 248 ++++++++++++++++++++++++++++++++++++------- > net/mptcp/protocol.h | 4 +- > 2 files changed, 210 insertions(+), 42 deletions(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel