From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E919C3E074E for ; Thu, 25 Jun 2026 12:15:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.21 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782389746; cv=fail; b=p2tbR9QzJW/NEd5vhJwykLnAQubPkSqLRwio7vXNvZbyqVAyhy+XFzmNmdKtHeUMe98bINfY2RmAZ/BhqW/XKP6AUB8dboiDP1yS+asf9+6e+MbuCHTIY4x1aNTBBUtyxUhOrg00HYkbC0Hm9uF3ZMCGvFPJwJxtt76+r/7jkuk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782389746; c=relaxed/simple; bh=oEU2blchPkcYMZXSGzdQu0t+BSA4+soI+xnhu3gsfqE=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=R00FPoQcy+M6CuQYCecsS/RVeB1z6o84H6ML6ORijCItUo9C5DR2ERZFKrQ6ox/9uBQE/iQ9pMNxTRTI6jIN5Lbf8zMGzWB5pmgLFffetvbDLcklxMh/ZiUo1DmHmgbA6J3idjWb75oMFpwyVUqGBLh+Fud/GqnlBQK9nifTeFc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZZDlJZ4Y; arc=fail smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZZDlJZ4Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782389744; x=1813925744; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=oEU2blchPkcYMZXSGzdQu0t+BSA4+soI+xnhu3gsfqE=; b=ZZDlJZ4YcKF177HD2dI0BGgJeK/LVdsPQdHGQHwAxx6Ml3lE52Sgh68O FAmqSiky8JOK5NsGJAqFR0jZMBbqDEQKwJc7nehuRUGqI4cyhOJjqQctb M5tKTSu+UsTgI1OwD1rlET718u9n6rJNINrEIAUOmX/H0jqAecFhyj97I VIN4GWu275p9KBVOel2ZDbyiTxFQyYCFn1fj+EpmgdCTQ4iAU77ozj+FG 0AEOhXlxQidEcDfuf8e4pYWGdsqhjqnPQj6NktjlDyby4WVu1jBuZtMM/ s3qbw31eIGzWkQ9oAf+dMGcp/zQrfzuj/zZB6WZyVi+w+fntjWX5Ob142 Q==; X-CSE-ConnectionGUID: tshryI+mQDa9Tw7OzPGoGg== X-CSE-MsgGUID: /0akK72rTpia/XTNe1atyg== X-IronPort-AV: E=McAfee;i="6800,10657,11827"; a="83047634" X-IronPort-AV: E=Sophos;i="6.24,224,1774335600"; d="scan'208";a="83047634" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2026 05:15:43 -0700 X-CSE-ConnectionGUID: to6ilUwYTVG35uGlEePTYw== X-CSE-MsgGUID: bT3YnCFRTHm0Exd1fkU5cw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,224,1774335600"; d="scan'208";a="251118563" Received: from fmsmsx901.amr.corp.intel.com ([10.18.126.90]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2026 05:15:44 -0700 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 25 Jun 2026 05:15:42 -0700 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Thu, 25 Jun 2026 05:15:42 -0700 Received: from DM1PR04CU001.outbound.protection.outlook.com (52.101.61.57) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 25 Jun 2026 05:15:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZIhDdy8F4cQuoUhzMdlIqHa0odQwDYDdCk1NAq9RLSpiiE2/hYlghUlqDYnSSTay9oEkKlGfzSecBkI/yHH9wFWbYXx1RnwUWKb18sMeVnGVxAxXOzIYBArd8MuXDXqVJ5EmdEhLI38+l7MFst7IKzBMB4/aUdI52m/Gf5YRaIraP5ehHmuCYlDl9i9/Hf/CqG2ptyheRVwxLq9+1Ko66dQalEYlHjZ9qZSN+sSGEduidT6NiP7nsTZTDjNs/uvHI62se0Ow9iVJ+Ngs9f+rd+N2yA+OJDeO1OgF5gWU+TEnjlqQ/h6jyci1My4bKa/0sNZXUyqHfE8ZRlydKkp3og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SufLLtY/EIFZ2fH8McQTuxnmm014y0toOaN8RJMBuDI=; b=dRK44Ikn8tz2shjs9lmWPON2XAMXUrB1U0WA5rOk62SY5dvef7lI4YQck3xGKKGS6BoUBiLoZARxa6hrfJSUm+IqMyOutE6Z6vQm84IdNqNY3rdI+ZF4IwzabTS3LlIUWsYj1tvDGgJFlE+K2F294+Y8juJzhee5jqSqiXmzr0bmBLwGURYaC2fIX1iiEEn83MtO9oYaoiOIexSd3ZaYr7RbQHtYixXMKjBxO95En7ltVE5V0wfo1LlzMCp/mfPAburznytK3e9WmRYcUBOAdSa2+JCJuPPXyNCaQsc3hUDImJXkR15JyKJ2KOsTtoyOvMcRJfn/Rvv7XTi2DEbh4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from LV3PR11MB8508.namprd11.prod.outlook.com (2603:10b6:408:1b4::8) by DS7PR11MB7737.namprd11.prod.outlook.com (2603:10b6:8:e1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.17; Thu, 25 Jun 2026 12:15:39 +0000 Received: from LV3PR11MB8508.namprd11.prod.outlook.com ([fe80::a1e8:1786:e5d1:8e51]) by LV3PR11MB8508.namprd11.prod.outlook.com ([fe80::a1e8:1786:e5d1:8e51%5]) with mapi id 15.21.0139.018; Thu, 25 Jun 2026 12:15:38 +0000 Message-ID: <1d226d1e-290d-4220-a1a6-9487c210329a@intel.com> Date: Thu, 25 Jun 2026 14:17:53 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH net v7 2/4] i40e: skip unnecessary VF reset when setting trust To: Simon Horman , CC: , , , , , , , , References: <20260623101800.991293-3-jtornosm@redhat.com> <20260624163050.1145761-1-horms@kernel.org> From: Przemek Kitszel Content-Language: en-US In-Reply-To: <20260624163050.1145761-1-horms@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TL0P290CA0002.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:5::10) To LV3PR11MB8508.namprd11.prod.outlook.com (2603:10b6:408:1b4::8) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR11MB8508:EE_|DS7PR11MB7737:EE_ X-MS-Office365-Filtering-Correlation-Id: d7f3e61c-153e-45f3-300f-08ded2b377f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|11063799006|5023799004|56012099006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: NgSfXOA78RwtN5ZSsqeHj/JCFagxNNAk9XJjOP3gXh9t0G+ZPbq+4ZsKYY6tNtWQHGHBw2pkPGr3hgTrPfDsu9e/norBjg55KXZ1vj3MxbjEXZDCfuhlWNDZVjaB1fBOfHBo5FB/Suy4kpIfAK9Gi2Q+booaF5qgCr4sBi8LrTPLz5s5o8bnDZRprlCkcIdBGylAlblxyD28joDxcC7U7lGXx980ckMJH781U/hq86jEOr70cBDTubvd6uPbvgtm/maw6xWwgNz6EpX5GaeV4ywMgxnBMNXasV/LL4ww9H+OyTxAslnYYOxS6F2AO/SB3BUI5c6cIBKzQENVnXqsLPBAL4+52zf8r0F/1jhY2Cb6BtWlH66b7ujhO3Isu/OuBSsWq2NIuevogvksTufwCfKIbjPeklZeQOID1XULv7Rz9tB9Lc7Dx+VC8Bn8M1uBPayV3pQBKrny9ytbcLsRkzgGU8I2T/JhVRslm238bm/j4ODJyeJYjS4+N27vwVZr9fegDmVnYFURQ5Q9zoEK9iPtlSYUfQjTIwG+60QTHpkvODHhDY1o3FATLfsxu84HDFeSUc6a3zBOUn4Nzxk0LWDqHPkNhkIHrgFg61i++Y9YWBzN2kypVpYGuZNchhxn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV3PR11MB8508.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(11063799006)(5023799004)(56012099006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTB2UkZkeEMzMXQydjdTK2RoZnFEVFZvL2pmRHkzY3BmR2cvcXNpaFd3NTEw?= =?utf-8?B?MzZtR003TGw4amFlMzBmQWloU3hNMm9LWGU5NmdFM2FsUlQzVVNoWXQzQ2VN?= =?utf-8?B?bkVvWmU5VE82Znp4eUlQUGt4QkFFM0RvaUpCY2M1RWVOTXhCZktBOENIdGhP?= =?utf-8?B?YXhRWVhhU01sV3ltQmM5cldpZ0lhbHBuU3hKQWluTDRQdXMxUWZvOHZWU0tG?= =?utf-8?B?dmY0MUtEQmNLQ2k1d1hQM2c0RncveVM2NE9udnM1dXg5YnRjVjlSSE9KUEpV?= =?utf-8?B?TW5RYVNKNDBpYThFTk0wREdIdStKNSthRHpJU09EazlOa2Q3cUgvY1J5b2hu?= =?utf-8?B?ZWtjS0FRVEdxZ0V3NU8rVStDbVAxTkUyT2dYczNuMW1jZ0RLbnJqSEdKTkR0?= =?utf-8?B?UEtMbC9CRGZadll3U1pjblk2MTdCby9pc2JWNXlGaGFkNXpKYkF3VHgxSmFX?= =?utf-8?B?bzkrUU1sL0ZqbTMzb0xzTW01eUQyOVg4Tjd0VzJZbmp2M0VadUFxTERFcUxz?= =?utf-8?B?blNTVy9VWkdNdEZ0Vyt0VURObE9KRGdrVzE0VEVldkwvK0M4L2NZV0x0Q1Bu?= =?utf-8?B?SG9aS1h3bzZlaDRHdUtpbG0wSTIxd1hJVk80UmRCVUVsSFlhTFdubyt5NkpP?= =?utf-8?B?WWNZeDNrVHVMMGd4RC9xNDlEejZ1ZHNrNU5vNU5jeU1lWkdrRTlMVVM4T0lw?= =?utf-8?B?L3dlMFRONGdrSFZCamt5NFJIclVyclRWWWZZZDZ5My9HaVg3eElPNHRCN2lx?= =?utf-8?B?cVF1cnJGb1lZNnNDMmMxZE9lMFl6eXBBekNuV1ZUcWJSbnJtYXNUYUFGYzU3?= =?utf-8?B?d2lqYnp2Y3ZKbFdKQU1ETzNSZ3U3NldQWmM5WUhhWHlSK3lzR0k4bXlpYTdW?= =?utf-8?B?RUQrTktta3FmUG1Sd2tHQ0Nxdjg4b2NxNkZQZVJtWW1NK1pER2RPaE5nYmw2?= =?utf-8?B?SmozaGVQQmE1ZHV3UDVWd1dXWVY2UVBHQ2d1UVQ3Y0NOdXJ4MGZkWjBYM3Rx?= =?utf-8?B?ZTJlSUhKRUZKYktMRXMrOXgzc0g0b1pTc0FteXdRZnVFVWhFWEFwOUNnMk9n?= =?utf-8?B?T3h2bUhWUGpZZ2lkbzdIRU1jOG11cUVyN3dHVnNrcFRCaHozZ0ZObVZLMEJR?= =?utf-8?B?SG9RYzNQMmJZdTN1YlJxUm84ckU2U3BzNVBURVVhbEdwRFZkWFRNT01YTVhS?= =?utf-8?B?Mzc5WkRYQkNQeUdaZTFFT05ORjVlM2NyTW5vQ1l0R1FQcFE5NStxZEVTcjd6?= =?utf-8?B?OXZNL1Q1aGVpUml1d3l2Q0pEdDVKRnlFdHpWUUVZL3hIYVVmV0lneUxKWURW?= =?utf-8?B?NUV0QVZkUStoQ2EvaFBvZzEwUjBsdnh1dnR4OVl4Qjdvb0FNSE5CVXZqSGdh?= =?utf-8?B?U3p1YlV2dk5NWjRRRGlLTmRJd05wSlFtdy9KbytMOGV2MmVmU1RsSG1mbWdw?= =?utf-8?B?NVZFYS9oNVNGcngxME9way9sWExFWkF3Y09qTy9KZVFIaERrZTA3Yk1EOHRj?= =?utf-8?B?ZC9RQ0ZPaDE2WjY5SFBQLzdJOVpMNkNVOGJCNkpkMmZiTHY3TmZmNnNFamlW?= =?utf-8?B?TGRBMFlwRXlXYW1qMWpSMjlQTnJyRnB5YW9LRC9OVjg2YmpMelZBeC82NGlC?= =?utf-8?B?VVgwcDk4Q1RzemhKUVJzV2tXM0JLNUYwQm9wS2UrMnJOYzZYZ3J2L0Y2RGgv?= =?utf-8?B?SFpyL3Z2NXU4M2RJQjd6Q0VleU5xK0NNNkMvYmNXOVhFVG96bVJwVEFCWDVy?= =?utf-8?B?a2dGZFNrS2xoN2kvZC9udGpGd0tXV3VYSmtFcnF3STU2RmdDTmxOLzFHQUhR?= =?utf-8?B?S0FQRU03ejQxd2o3L3NzSFByMUN5UUN4VUE3OGZ1bGxIVVpCU2tydldtQ3Uw?= =?utf-8?B?U2JBNXBOaGthSG1yLzl5M2dydStLWU5PU0dadE8rSHZwd3YzbHgwVVE0TU04?= =?utf-8?B?bWtLWlVYS1p1Q1dQQWJLNERKS2NPU0ZmbjE2VlczS3QvZ1R5Rk5uY3RpRVFw?= =?utf-8?B?Q1ZoK2ZxNW92TFhYMkpleGFIZHY5aFlIc1YzL2h2SWRtcGpvNVdUV0l1MUox?= =?utf-8?B?NktBZEV3U1pRL1lGZG5QSTljZkh5Q0FOaVlZVGErYzZ4a0dZdzhtVUNSTEhm?= =?utf-8?B?bC82bU8wYnJ2a1RXZElPWE5vWFVSaXl2UFRFSVlEdUdiOEtzV3VrUkFnbXRW?= =?utf-8?B?MXlpMnF1UEhUSmdya3RnaU1TNFNRQTFVbjg2S3B5YTk1RUlncFFVaVNlTzFt?= =?utf-8?B?c2JvUVFDRUlyRUMycXd1SHdpaEVET1RWSUNXem00NlFQTVNJS3RZblJtakE5?= =?utf-8?B?Mk5mZGh3UWlmMDRkZTF0ZjBtS3pHUkNjS3BSUWx2ejV1MVFCQyt6alZGeVJa?= =?utf-8?Q?EBPcE6i8BauWtvqc=3D?= X-Exchange-RoutingPolicyChecked: jWXLfb1DrCpG2Wx0q+DS1u3OiQ2d86o4aw7tlgYhU403SievGqPF2PtFt1CCJJNjeBo9AOk/UM5KX7b69m0/8A5XGMR3Kf8Mk8Cq3PYovfd5DaxHFYdpe4iL/03eRSUSZSEniMkow5nh1JLzdkxLH6Bf/2bWLsHFg8V39jYPuIX/gFnqNnGFrfEU7JFexOyebujHHCwOf0Wt3WCh0Gyshw4TgL8iWCyI0qlAHqK1PhG/TMM8PP8gWitzYkYTW+zuM70whxJnGcNhPi8a19Un9NVsQ8p0Qjg6QxMIegKuOvUIMn4Uye6OeDximA0ckyLygoZJNGFvHMiG9WzagIYY1w== X-MS-Exchange-CrossTenant-Network-Message-Id: d7f3e61c-153e-45f3-300f-08ded2b377f3 X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8508.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2026 12:15:38.8547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c1Dwh1ElXoj0XZkYICLzmLJWuKtpWdq5RdlZw06RMUOsew4wXysiaMdXyJpeT+P6wU16CL7PbppCORwp1rLk2UOUuMqQ87ab0XgrN57irC4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7737 X-OriginatorOrg: intel.com On 6/24/26 18:30, Simon Horman wrote: > This is an AI-generated review of your patch. The human sending this > email has considered the AI review valid, or at least plausible. > Full review at: https://netdev-ai.bots.linux.dev/sashiko/ > --- > i40e: skip unnecessary VF reset when setting trust > > This patch avoids the ~10 second VF reset delay on trust changes by > flipping the I40E_VIRTCHNL_VF_CAP_PRIVILEGE bit directly, and only > resorting to a full reset when revoking trust from a VF that has > advanced features (ADQ, cloud filters, UC/MC promisc) configured. > >> diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c >> index a26c3d47ec15..0cc434b26eb8 100644 >> --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c >> +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c >> @@ -4987,19 +5004,20 @@ int i40e_ndo_set_vf_trust(struct net_device *netdev, int vf_id, bool setting) >> set_bit(__I40E_MACVLAN_SYNC_PENDING, pf->state); >> pf->vsi[vf->lan_vsi_idx]->flags |= I40E_VSI_FLAG_FILTER_CHANGED; >> >> - i40e_vc_reset_vf(vf, true); >> + /* Reset only if revoking trust and VF has advanced features configured */ >> + if (!setting && >> + (vf->adq_enabled || vf->num_cloud_filters > 0 || >> + test_bit(I40E_VF_STATE_UC_PROMISC, &vf->vf_states) || >> + test_bit(I40E_VF_STATE_MC_PROMISC, &vf->vf_states))) { > > [High] > Does this revoke-trust heuristic miss MAC/VLAN filters that were only > installable while the VF was trusted? No. > > A trusted VF is allowed to add many more MAC addresses than > I40E_VC_MAX_MAC_ADDR_PER_VF (i40e_check_vf_permission() uses > I40E_VC_MAX_MACVLAN_PER_TRUSTED_VF) and more than I40E_VC_MAX_VLAN_PER_VF > VLANs. These quotas are enforced only at add-time. > > The previous always-reset path went through i40e_vc_reset_vf() -> > i40e_cleanup_reset_vf() -> i40e_free_vf_res() -> i40e_vsi_release(), > which destroyed the VSI and its mac_filter_hash, and reset > vf->num_vlan = 0. Current "reset only on revoke" does exactly the same. > > The new fast path only flips the PRIVILEGE bit, leaving any NOPE. New "fast path" only *TESTS* the PRIVILEGE bit, it does not "clear" it in fast path. This is just negated/wrong/inverted logic on AI side