From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch net-next 1/2] mlxsw: spectrum: Add extack for VLAN enslavements
Date: Fri, 6 Oct 2017 12:24:33 -0600 [thread overview]
Message-ID: <1d2e6cb3-6936-2f1d-5d06-22e8d1a00cd2@gmail.com> (raw)
In-Reply-To: <20171005214000.14022-2-jiri@resnulli.us>
On 10/5/17 3:39 PM, Jiri Pirko wrote:
> From: Ido Schimmel <idosch@mellanox.com>
>
> Similar to physical ports, enslavement of VLAN devices can also fail.
> Use extack to indicate why the enslavement failed.
>
> $ ip link add link enp1s0np1 name enp1s0np1.10 type vlan id 10
> $ ip link add name bond0 type bond mode 802.3ad
> $ ip link set dev enp1s0np1.10 master bond0
> Error: spectrum: VLAN devices only support bridge and VRF uppers.
>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2017-10-06 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 21:39 [patch net-next 0/2] mlxsw: Add more extack error reporting Jiri Pirko
2017-10-05 21:39 ` [patch net-next 1/2] mlxsw: spectrum: Add extack for VLAN enslavements Jiri Pirko
2017-10-06 18:24 ` David Ahern [this message]
2017-10-05 21:40 ` [patch net-next 2/2] mlxsw: spectrum: Propagate extack further for bridge enslavements Jiri Pirko
2017-10-06 18:24 ` David Ahern
2017-10-07 22:23 ` [patch net-next 0/2] mlxsw: Add more extack error reporting David Miller
2017-10-08 9:50 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d2e6cb3-6936-2f1d-5d06-22e8d1a00cd2@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).