From: "Kumar, M Chetan" <m.chetan.kumar@intel.com>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: Loic Poulain <loic.poulain@linaro.org>,
Johannes Berg <johannes@sipsolutions.net>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linuxwwan <linuxwwan@intel.com>
Subject: RE: [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing
Date: Sun, 20 Jun 2021 15:42:41 +0000 [thread overview]
Message-ID: <1d31c18cebf74ff29b5e388c4cd26361@intel.com> (raw)
In-Reply-To: <CAHNKnsR5X8Axttk_YX=fpi5h6iV191fLJ6MZqrLvhZvPe==mXA@mail.gmail.com>
Hi Sergey,
> On Tue, Jun 15, 2021 at 3:30 AM Sergey Ryazanov
> <ryazanov.s.a@gmail.com> wrote:
> > Since the last commit, the WWAN core will remove all our network
> > interfaces for us at the time of the WWAN netdev ops unregistering.
> > Therefore, we can safely drop the custom code that cleaning the list
> > of created netdevs. Anyway it no longer removes any netdev, since all
> > netdevs were removed earlier in the wwan_unregister_ops() call.
>
> Are you Ok with this change? I plan to submit a next version of the series. If
> you have any objections, I can address them in V2.
Changes looks fine.
> BTW, if IOSM modems have a default data channel, I can add a separate
> patch to the series to create a default network interface for IOSM if you tell
> me which link id is used for the default data channel.
Link id 1 is always associated as default data channel.
Thanks,
Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>
next prev parent reply other threads:[~2021-06-20 15:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 0:30 [PATCH net-next 00/10] net: WWAN link creation improvements Sergey Ryazanov
2021-06-15 0:30 ` [PATCH net-next 01/10] wwan_hwsim: support network interface creation Sergey Ryazanov
2021-06-15 0:30 ` [PATCH net-next 02/10] wwan: core: relocate ops registering code Sergey Ryazanov
2021-06-15 0:30 ` [PATCH net-next 03/10] wwan: core: require WWAN netdev setup callback existence Sergey Ryazanov
2021-06-15 0:30 ` [PATCH net-next 04/10] wwan: core: multiple netdevs deletion support Sergey Ryazanov
2021-06-15 0:30 ` [PATCH net-next 05/10] wwan: core: remove all netdevs on ops unregistering Sergey Ryazanov
2021-06-15 0:30 ` [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing Sergey Ryazanov
2021-06-20 15:20 ` Sergey Ryazanov
2021-06-20 15:42 ` Kumar, M Chetan [this message]
2021-06-20 16:53 ` Sergey Ryazanov
2021-06-29 14:14 ` Loic Poulain
2021-06-29 14:56 ` Kumar, M Chetan
2021-06-29 15:29 ` Loic Poulain
2021-06-30 5:11 ` Kumar, M Chetan
2021-06-15 0:30 ` [PATCH net-next 07/10] wwan: core: no more hold netdev ops owning module Sergey Ryazanov
2021-06-15 0:30 ` [PATCH net-next 08/10] wwan: core: support default netdev creation Sergey Ryazanov
2021-06-15 0:30 ` [PATCH net-next 09/10] net: mhi_net: create default link via WWAN core Sergey Ryazanov
2021-06-15 7:17 ` Loic Poulain
2021-06-20 13:51 ` Sergey Ryazanov
2021-06-21 6:53 ` Loic Poulain
2021-06-21 9:54 ` Sergey Ryazanov
2021-06-15 0:30 ` [PATCH net-next 10/10] wwan: core: add WWAN common private data for netdev Sergey Ryazanov
2021-06-15 7:31 ` Johannes Berg
2021-06-20 14:49 ` Sergey Ryazanov
2021-06-15 7:33 ` Loic Poulain
2021-06-20 14:39 ` Sergey Ryazanov
2021-06-21 7:37 ` Loic Poulain
2021-06-21 17:22 ` Sergey Ryazanov
2021-06-22 7:21 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d31c18cebf74ff29b5e388c4cd26361@intel.com \
--to=m.chetan.kumar@intel.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).