From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Monnet Subject: Re: [PATCH net-next] net: sched: fix tcf_block_get_ext() in case CONFIG_NET_CLS is not set Date: Thu, 4 Jan 2018 09:59:57 +0000 Message-ID: <1d6a9fe2-f1e2-116e-3f39-e81877db4cf3@netronome.com> References: <20180104013045.29510-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Jakub Kicinski , Linux Kernel Network Developers , oss-drivers@netronome.com, Jiri Pirko , Alexander Aring To: Cong Wang Return-path: Received: from mail-wm0-f46.google.com ([74.125.82.46]:38535 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbeADKAA (ORCPT ); Thu, 4 Jan 2018 05:00:00 -0500 Received: by mail-wm0-f46.google.com with SMTP id 64so2357949wme.3 for ; Thu, 04 Jan 2018 02:00:00 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi Cong, 2018-01-03 18:08 UTC-0800 ~ Cong Wang > On Wed, Jan 3, 2018 at 5:30 PM, Jakub Kicinski > wrote: >> From: Quentin Monnet >> >> The definition of functions tcf_block_get() and tcf_block_get_ext() >> depends of CONFIG_NET_CLS being set. When those functions gained extack >> support, only one version of the declaration of those functions was >> updated. Function tcf_block_get() was later fixed with commit >> 3c1490913f3b ("net: sch: api: fix tcf_block_get"). >> >> Change arguments of tcf_block_get_ext() for the case when CONFIG_NET_CLS >> is not set. > > There is one already: > https://patchwork.kernel.org/patch/10130849/ > Thanks! But this patch is the one I mentioned in the commit log: it fixes a different function, tcf_block_get(). My patch is an additional fix for tcf_block_get_ext(). Best regards, Quentin