From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF2562D for ; Mon, 29 May 2023 03:46:32 +0000 (UTC) Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE214B1; Sun, 28 May 2023 20:46:29 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 96CD1809C; Mon, 29 May 2023 11:46:21 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 29 May 2023 11:46:21 +0800 Received: from [192.168.120.43] (171.223.208.138) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 29 May 2023 11:46:20 +0800 Message-ID: <1dbf113c-7592-68bd-6aaf-05ff1d8c538c@starfivetech.com> Date: Mon, 29 May 2023 11:46:19 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg Content-Language: en-US To: Conor Dooley CC: , , , Peter Geis , Frank , "David S . Miller" , "Eric Dumazet" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , "Heiner Kallweit" , Russell King , Yanhong Wang References: <20230526090502.29835-1-samin.guo@starfivetech.com> <20230526090502.29835-2-samin.guo@starfivetech.com> <20230526-glutinous-pristine-fed571235b80@spud> From: Guo Samin In-Reply-To: <20230526-glutinous-pristine-fed571235b80@spud> Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX062.cuchost.com (172.16.6.62) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Re: [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver strength c= fg From: Conor Dooley to: Samin Guo data: 2023/5/27 > On Fri, May 26, 2023 at 05:05:01PM +0800, Samin Guo wrote: >> The motorcomm phy (YT8531) supports the ability to adjust the drive >> strength of the rx_clk/rx_data, the value range of pad driver >> strength is 0 to 7. >> >> Signed-off-by: Samin Guo >> --- >> .../devicetree/bindings/net/motorcomm,yt8xxx.yaml | 12 +++++++++++= + >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.ya= ml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> index 157e3bbcaf6f..29a1997a1577 100644 >> --- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> @@ -52,6 +52,18 @@ properties: >> for a timer. >> type: boolean >> =20 >> + motorcomm,rx-clk-driver-strength: >> + description: drive strength of rx_clk pad. >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ] >=20 > I think you should use minimum & maximum instead of these listed out > enums. Thanks Conor, This can be improved in the next version. You have also had this comment since v1 & were reminded of it on > v2 by Krzysztof: "What do the numbers mean? What are the units? mA?" >=20 The good news is that we just got some data about units from Motorcomm.=20 Maybe I can post the data show of the unit later after I get the complete= data. > This information should go into the binding, not sit in a thread on a > mailing list that noone will look at when trying to write a DT :( >=20 > Thanks, > Conor. > Yes=EF=BC=8Cwhen we have the complete 'unit' data, it will be placed in D= T. Best regards, Samin =20 >> + default: 3 >> + >> + motorcomm,rx-data-driver-strength: >> + description: drive strength of rx_data/rx_ctl rgmii pad. >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ] >> + default: 3 >> + >> motorcomm,tx-clk-adj-enabled: >> description: | >> This configuration is mainly to adapt to VF2 with JH7110 SoC. >> --=20 >> 2.17.1 >>