From: Eric Dumazet <eric.dumazet@gmail.com>
To: Saeed Mahameed <saeedm@mellanox.com>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
"kafai@fb.com" <kafai@fb.com>, Tariq Toukan <tariqt@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>
Subject: Re: [net RFC] net/mlx4_en: Use frag stride in crossing page boundary condition
Date: Thu, 14 Jun 2018 16:49:36 -0700 [thread overview]
Message-ID: <1ddecaaa-9613-03ba-d761-a4d3410c4f7d@gmail.com> (raw)
In-Reply-To: <77a87572d82deef1e035ec3b36027e8f6e0c1ea2.camel@mellanox.com>
On 06/14/2018 02:04 PM, Saeed Mahameed wrote:
> I was looking at the code without my fix :)
>
> with my fix:
> release = frags->page_offset + frag_info->frag_stride > PAGE_SIZE;
>
> for XDP: frag_info->frag_stride is PAGE_SIZE, so release will always be
> true regardless of PAGE_SIZE.
>
> So i guess i didn't quite understand your PowerPC concern.. can you
> elaborate ?
>
So your maths with PAGE_SIZE=65536 and MTU 9000
frag_stride is about 9344
So if the last chunk of the page has 9100 bytes, we wont be able to use it, while really we should be able to use it.
next prev parent reply other threads:[~2018-06-14 23:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 0:53 [net RFC] net/mlx4_en: Use frag stride in crossing page boundary condition Saeed Mahameed
2018-06-14 2:30 ` Eric Dumazet
2018-06-14 18:56 ` Saeed Mahameed
2018-06-14 19:12 ` Eric Dumazet
2018-06-14 20:47 ` Saeed Mahameed
2018-06-14 20:53 ` Saeed Mahameed
2018-06-14 21:04 ` Saeed Mahameed
2018-06-14 23:49 ` Eric Dumazet [this message]
2018-06-19 18:05 ` Saeed Mahameed
2018-06-20 0:25 ` Eric Dumazet
2018-06-20 23:41 ` Saeed Mahameed
2018-06-21 0:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ddecaaa-9613-03ba-d761-a4d3410c4f7d@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).